-
-
Notifications
You must be signed in to change notification settings - Fork 827
Conversation
Co-authored-by: Michael Telatynski <[email protected]>
Co-authored-by: Michael Telatynski <[email protected]>
Co-authored-by: Michael Telatynski <[email protected]>
Co-authored-by: Michael Telatynski <[email protected]>
Co-authored-by: Michael Telatynski <[email protected]>
Co-authored-by: Michael Telatynski <[email protected]>
Co-authored-by: Michael Telatynski <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Good stuff!
I wonder if we could tweak the radio button colour when unchecked to Dark/Quinary? https://www.figma.com/file/tepA3ELWBE5v4O2WB8PqWn/Polls?node-id=496%3A54285
And for the votes text to be right aligned with the bar with equal number of padding that you have on the left side. If it is 8px currently, can we do 12px on each side instead?
Ah no, my bad - it goes wrong when the poll is ended. Working on it. |
OK, @gaelledel I think I've completed the changes you asked for. |
Co-authored-by: Michael Telatynski <[email protected]>
Yes, in both themes it is quaternary. My latest change makes it quinary in both. Is that right? |
This reverts commit 9fb0bc4.
We agreed to go back to quaternary for both themes. Done in f697a17 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM otherwise
This change allows us to end a poll and see the results highlighted and with a little trophy symbol:
This change is marked as an internal change (Task), so will not be included in the changelog.
Preview: https://61b0c70c1a94ab2550cb7837--matrix-react-sdk.netlify.app
⚠️ Do you trust the author of this PR? Maybe this build will steal your keys or give you malware. Exercise caution. Use test accounts.