Skip to content
This repository has been archived by the owner on Sep 11, 2024. It is now read-only.

ChatCreateOrReuse show only rooms both you and the other party still in #3225

Merged
merged 1 commit into from
Jul 16, 2019

Conversation

t3chguy
Copy link
Member

@t3chguy t3chguy commented Jul 15, 2019

Before
image
After
image

Fixes element-hq/element-web#10218

Signed-off-by: Michael Telatynski [email protected]

@t3chguy t3chguy requested a review from a team July 15, 2019 22:09
Copy link
Member

@turt2live turt2live left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm, and merging despite this dialog quickly disappearing.

@turt2live turt2live merged commit e53b922 into develop Jul 16, 2019
@t3chguy
Copy link
Member Author

t3chguy commented Jul 19, 2019

lgtm, and merging despite this dialog quickly disappearing.

Any more info on this for people outside of the inner circle @turt2live ?

Thanks

@bwindels
Copy link
Contributor

lgtm, and merging despite this dialog quickly disappearing.

Any more info on this for people outside of the inner circle @turt2live ?

Thanks

We're working on only having a single room for DMs per contact.

@t3chguy
Copy link
Member Author

t3chguy commented Jul 19, 2019

How would that work with existing rooms, say I already have 4 rooms to chat with X, would it just randomly pick one or would this dialog stay around to handle existing cases or would Riot somehow force me to merge them

@bwindels
Copy link
Contributor

How would that work with existing rooms, say I already have 4 rooms to chat with X, would it just randomly pick one or would this dialog stay around to handle existing cases or would Riot somehow force me to merge them

Not sure, haven't been involved really. See https://github.com/vector-im/riot-web/issues/7315 if you want to weigh in.

@turt2live
Copy link
Member

There'll be a MSC which explains it before riot actually gets code for it. Still working out the details.

@t3chguy t3chguy deleted the t3chguy/create_reuse_dialog_hide_left branch May 25, 2020 18:12
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Create a new chat or reuse an existing one includes rooms you're no longer in
3 participants