This repository has been archived by the owner on Sep 11, 2024. It is now read-only.
Prevent autocomplete on paste, and verserev-ing text before and after : #3210
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bwindels
force-pushed
the
bwindels/prevent-autocomplete-on-paste
branch
from
e33a938 to
dedf978
Compare
turt2live
approved these changes
Jul 11, 2019
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes element-hq/element-web#9818
Fixes element-hq/element-web#9985
Don't open autocomplete when pasting or dropping text.
Also, when pasting a link into an empty editor, we were inserting parts at index -1 (as the position was not found), and then 0, so the second pill-candidate part (:..) would be prepended to the first plain part (https). That is fixed, but also wouldn't happen anymore since pasting doesn't trigger autocomplete anymore, so you only create one plain part, no pill-candidate.
I couldn't reproduce with the exact steps in element-hq/element-web#9985 anymore, but suspect part of it might have been solved with the caret work I did before.