Skip to content
This repository has been archived by the owner on Sep 11, 2024. It is now read-only.

Switch from graphemer to Intl.Segmenter #12697

Merged
merged 1 commit into from
Jun 26, 2024
Merged

Switch from graphemer to Intl.Segmenter #12697

merged 1 commit into from
Jun 26, 2024

Conversation

t3chguy
Copy link
Member

@t3chguy t3chguy commented Jun 25, 2024

Closes #12617

@t3chguy t3chguy added the T-Task Refactoring, enabling or disabling functionality, other engineering tasks label Jun 25, 2024
@t3chguy t3chguy self-assigned this Jun 25, 2024
@t3chguy t3chguy marked this pull request as ready for review June 25, 2024 15:23
@t3chguy t3chguy requested review from a team as code owners June 25, 2024 15:23
@t3chguy t3chguy requested review from MidhunSureshR and dbkr June 25, 2024 15:23
Copy link
Member

@dbkr dbkr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

otherwise looks sane

@@ -12,7 +12,7 @@
"outDir": "./lib",
"declaration": true,
"jsx": "react",
"lib": ["es2021", "dom", "dom.iterable"],
"lib": ["es2022", "dom", "dom.iterable"],
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Unintentional commit?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nope, it is necessary for the types for Intl.Segmenter

@t3chguy t3chguy added this pull request to the merge queue Jun 26, 2024
Merged via the queue into develop with commit 86a95cf Jun 26, 2024
34 checks passed
@t3chguy t3chguy deleted the t3chguy/segmenter branch June 26, 2024 09:51
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
T-Task Refactoring, enabling or disabling functionality, other engineering tasks
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants