This repository has been archived by the owner on Sep 11, 2024. It is now read-only.
-
-
Notifications
You must be signed in to change notification settings - Fork 827
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Michael Telatynski <[email protected]>
* Migrate send_event.spec.ts from Cypress to Playwright Signed-off-by: Michael Telatynski <[email protected]> * Migrate read_events.spec.ts from Cypress to Playwright Signed-off-by: Michael Telatynski <[email protected]> * Migrate kick.spec.ts from Cypress to Playwright Signed-off-by: Michael Telatynski <[email protected]> * Migrate get-openid-token.spec.ts from Cypress to Playwright Signed-off-by: Michael Telatynski <[email protected]> * Migrate layout.spec.ts from Cypress to Playwright Signed-off-by: Michael Telatynski <[email protected]> * Migrate events.spec.ts from Cypress to Playwright Signed-off-by: Michael Telatynski <[email protected]> * Migrate stickers.spec.ts from Cypress to Playwright Signed-off-by: Michael Telatynski <[email protected]> * Migrate widget-pip-close.spec.ts from Cypress to Playwright Signed-off-by: Michael Telatynski <[email protected]> * Fix types Signed-off-by: Michael Telatynski <[email protected]> * Add screenshot Signed-off-by: Michael Telatynski <[email protected]> * expect.poll to stabilise test Signed-off-by: Michael Telatynski <[email protected]> --------- Signed-off-by: Michael Telatynski <[email protected]>
Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
Co-authored-by: github-merge-queue <[email protected]>
…#12037) Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
* Update dependency stylelint to v16 * Bump stylelint-scss for compat Signed-off-by: Michael Telatynski <[email protected]> --------- Signed-off-by: Michael Telatynski <[email protected]> Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com> Co-authored-by: Michael Telatynski <[email protected]>
…12031) * Migrate send_event.spec.ts from Cypress to Playwright Signed-off-by: Michael Telatynski <[email protected]> * Migrate read_events.spec.ts from Cypress to Playwright Signed-off-by: Michael Telatynski <[email protected]> * Migrate kick.spec.ts from Cypress to Playwright Signed-off-by: Michael Telatynski <[email protected]> * Migrate get-openid-token.spec.ts from Cypress to Playwright Signed-off-by: Michael Telatynski <[email protected]> * Discard changes to playwright/pages/client.ts --------- Signed-off-by: Michael Telatynski <[email protected]>
* Migrate timeline.spec.ts from Cypress to Playwright Signed-off-by: Michael Telatynski <[email protected]> * Monospace font for timestamps Signed-off-by: Michael Telatynski <[email protected]> * More expects Signed-off-by: Michael Telatynski <[email protected]> * delint Signed-off-by: Michael Telatynski <[email protected]> --------- Signed-off-by: Michael Telatynski <[email protected]>
Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com> Co-authored-by: Michael Telatynski <[email protected]>
Co-authored-by: David Baker <[email protected]>
* Attach synapse logs to failed Playwright test runs Signed-off-by: Michael Telatynski <[email protected]> * Update playwright/plugins/homeserver/index.ts --------- Signed-off-by: Michael Telatynski <[email protected]>
Signed-off-by: Michael Telatynski <[email protected]>
…matrix-org#12053) * Prevent Cypress typechecking react-sdk components without strict mode This prevented us from switching to `forwardRef` in a bunch of places due to it behaving different with & without strict mode. Signed-off-by: Michael Telatynski <[email protected]> * Update global.d.ts --------- Signed-off-by: Michael Telatynski <[email protected]>
Co-authored-by: github-merge-queue <[email protected]>
Signed-off-by: Michael Telatynski <[email protected]>
* Change permission for synapse to work * Upgrade playwright
… reset (matrix-org#12059) * Remove redundant `forceReset` parameter This was always true, so let's get rid of it. Also some function renames. * Factor out new `withSecretStorageKeyCache` helper ... so that we can use the cache without the whole of `accessSecretStorage`. * Cache secret storage key during cross-signing reset * Playwright test for resetting cross-signing * CrossSigningPanel: Silence annoying react warnings React complains if we don't include an explicit `tbody`. * Simple unit test of reset button
* Add method to send text message * Add dockerUrl to HomeServerConfig * Implement sliding sync proxy * Convert tests * Reload page after applying labs feature * Remove converted files * Remove timeout * Remove sliding-sync * Remove proxy import * Remove reference to proxy * wait for load * Update date * Convert enableLabsFeature to separate fixture * Enable feature in fixture * Skip over config and just write to local-storage * Rename fixture * Fix room header test * Use type inference * Override config instead of setting localstorage * Set default language * Always add labs feature * Put this one test into a separate describe block * Move labs lag within describe block
Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
* Convert tests * Use existing code * Remove code from settings * Change names * Change comment * Update comment
…12068) * Fix incorrect type annotation on `cacheSecretStorageKey` `cacheSecretStorageKey` is passed a `SecretStorageKeyDescription` (aka a `ISecretStorageKeyInfo`), and has done ever since matrix-org/matrix-js-sdk#1502. `AddSecretStorageKeyOpts`is something else, though until recently some of the properties on `AddSecretStorageKeyOpts` were incorrectly marked as optional, so this went unnoticed since it was broken by matrix-org#11217. * playwright has the same problem
It appears the bug with these tests was just that the MessageBuilder wasn't setting the thread relation on the reply messages as this didn't happen trying to repro it manually, so fix the builder and re-enable the tests. The flip side of this is that it implies buggy clients that don't set thread relations properly will cause stuck notifs in Element Web. I've filed this as element-hq/element-web#26787
* Implement method to wait for next sync * Add timeline coded to app page * Convert network plugin * Add createBot fixture * Convert lazy-loading test * Remove cypress test * Remove converted files * Remove imports * Fix date in copyright header Co-authored-by: Michael Telatynski <[email protected]> * Fix date in copyright header Co-authored-by: Michael Telatynski <[email protected]> * Use proper method to send messages * Fix sliding-sync test * Address comments * Move code to timeline --------- Co-authored-by: Michael Telatynski <[email protected]>
* Fix thread root skipped tests * Add comment about collapsed content in `redactions.spec.ts` --------- Co-authored-by: David Baker <[email protected]>
…atrix-org#12072) * Improve AccessibleButton props & docs Signed-off-by: Michael Telatynski <[email protected]> * Improve AccessibleTooltipButton props docs Signed-off-by: Michael Telatynski <[email protected]> * Simplify roving tab index hook usage Signed-off-by: Michael Telatynski <[email protected]> * Ditch RefObject type casts Signed-off-by: Michael Telatynski <[email protected]> * Convert AccessibleTooltipButton to a Functional Component Signed-off-by: Michael Telatynski <[email protected]> --------- Signed-off-by: Michael Telatynski <[email protected]>
Signed-off-by: Timo K <[email protected]>
* Fix wrong type enum usage Signed-off-by: Michael Telatynski <[email protected]> * Use improved type definition for forwardRef which enables Generic props Signed-off-by: Michael Telatynski <[email protected]> * Improve AccessibleButton & related Props types Signed-off-by: Michael Telatynski <[email protected]> * Remove useless comment Signed-off-by: Michael Telatynski <[email protected]> --------- Signed-off-by: Michael Telatynski <[email protected]>
…#12064) * Iterate landmarks around the app in order to improve a11y Signed-off-by: Michael Telatynski <[email protected]> * Add missing aria-label Signed-off-by: Michael Telatynski <[email protected]> * Update snapshots Signed-off-by: Michael Telatynski <[email protected]> * i18n Signed-off-by: Michael Telatynski <[email protected]> * Fix tests Signed-off-by: Michael Telatynski <[email protected]> * Iterate Signed-off-by: Michael Telatynski <[email protected]> * Update screenshots which have changed a fraction due to default heading margins being different in different landmarks Signed-off-by: Michael Telatynski <[email protected]> --------- Signed-off-by: Michael Telatynski <[email protected]>
…-org#12054) * Prevent Cypress typechecking react-sdk components without strict mode This prevented us from switching to `forwardRef` in a bunch of places due to it behaving different with & without strict mode. Signed-off-by: Michael Telatynski <[email protected]> * Update global.d.ts * Switch AccessibleButton and derivatives to using `forwardRef` Signed-off-by: Michael Telatynski <[email protected]> * Add missing ref={ref} Signed-off-by: Michael Telatynski <[email protected]> * Iterate Signed-off-by: Michael Telatynski <[email protected]> * Ensure RefObjects are used consistently Signed-off-by: Michael Telatynski <[email protected]> * Re-add WysiwygAutocomplete displayname Signed-off-by: Michael Telatynski <[email protected]> * Fix forwardRef types Signed-off-by: Michael Telatynski <[email protected]> * Add comments Signed-off-by: Michael Telatynski <[email protected]> * Remove unused export Signed-off-by: Michael Telatynski <[email protected]> * Readd comment Signed-off-by: Michael Telatynski <[email protected]> * Iterate types & comments Signed-off-by: Michael Telatynski <[email protected]> * Apply suggestions from code review Co-authored-by: Richard van der Hoff <[email protected]> * Add comment Signed-off-by: Michael Telatynski <[email protected]> * Iterate Signed-off-by: Michael Telatynski <[email protected]> * Improve comment Signed-off-by: Michael Telatynski <[email protected]> --------- Signed-off-by: Michael Telatynski <[email protected]> Co-authored-by: Richard van der Hoff <[email protected]>
…matrix-org#12076) Signed-off-by: Michael Telatynski <[email protected]>
…atrix-org#12079) Signed-off-by: Michael Telatynski <[email protected]>
* Switch Pill to using Compound Tooltips Signed-off-by: Michael Telatynski <[email protected]> * Switch E2EIcon to using Compound Tooltips Signed-off-by: Michael Telatynski <[email protected]> * Update tests & snapshots Signed-off-by: Michael Telatynski <[email protected]> --------- Signed-off-by: Michael Telatynski <[email protected]>
Co-authored-by: github-merge-queue <[email protected]>
Thanks for opening this pull request, unfortunately we do not accept contributions from the main branch of your fork, please re-open once you switch to an alternative branch for everyone's sanity. See https://github.com/matrix-org/matrix-js-sdk/blob/develop/CONTRIBUTING.md |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Checklist
This PR currently has none of the required changelog labels.
A reviewer can add one of:
T-Deprecation
,T-Enhancement
,T-Defect
,T-Task
to indicate what type of change this is, or addType: [enhancement/defect/task]
to the description and I'll add them for you.