Skip to content
This repository was archived by the owner on Sep 11, 2024. It is now read-only.

Jest test coverage for Lifecycle.persistCredentials #11243

Merged
merged 9 commits into from
Jul 19, 2023

Conversation

kerryarchibald
Copy link
Contributor

@kerryarchibald kerryarchibald commented Jul 12, 2023

For element-hq/element-web#25444

Test Lifecycle.persistCredentials before refactoring to add refresh token for OIDC work

Checklist

  • Tests written for new code (and old code if feasible)
  • Linter and other CI checks pass
  • Sign-off given on the changes (see CONTRIBUTING.md)

This change is marked as an internal change (Task), so will not be included in the changelog.

@kerryarchibald kerryarchibald added the T-Task Refactoring, enabling or disabling functionality, other engineering tasks label Jul 12, 2023
@kerryarchibald kerryarchibald marked this pull request as ready for review July 12, 2023 06:07
@kerryarchibald kerryarchibald requested a review from a team as a code owner July 12, 2023 06:07
@kerryarchibald kerryarchibald added this pull request to the merge queue Jul 19, 2023
Merged via the queue into develop with commit 689089d Jul 19, 2023
@kerryarchibald kerryarchibald deleted the kerry/25708/test-persist-credentials branch July 19, 2023 08:04
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
T-Task Refactoring, enabling or disabling functionality, other engineering tasks
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants