Skip to content
This repository has been archived by the owner on Sep 11, 2024. It is now read-only.

Enable strictNullChecks and noImplicitAny #11194

Merged
merged 1 commit into from
Jul 6, 2023
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 5 additions & 1 deletion src/components/views/dialogs/BaseDialog.tsx
Original file line number Diff line number Diff line change
Expand Up @@ -94,7 +94,11 @@ export default class BaseDialog extends React.Component<IProps> {
public constructor(props: IProps) {
super(props);

this.matrixClient = MatrixClientPeg.get();
// XXX: The contract on MatrixClientContext says it is only available within a LoggedInView subtree,
// given that modals function outside the MatrixChat React tree this simulates that. We don't want to
// use safeGet as it throwing would mean we cannot use modals whilst the user isn't logged in.
// The longer term solution is to move our ModalManager into the React tree to inherit contexts properly.
this.matrixClient = MatrixClientPeg.get()!;
}

private onKeyDown = (e: KeyboardEvent | React.KeyboardEvent): void => {
Expand Down
6 changes: 5 additions & 1 deletion src/components/views/dialogs/ScrollableBaseModal.tsx
Original file line number Diff line number Diff line change
Expand Up @@ -43,7 +43,11 @@ export default abstract class ScrollableBaseModal<
}

protected get matrixClient(): MatrixClient {
return MatrixClientPeg.get();
// XXX: The contract on MatrixClientContext says it is only available within a LoggedInView subtree,
// given that modals function outside the MatrixChat React tree this simulates that. We don't want to
// use safeGet as it throwing would mean we cannot use modals whilst the user isn't logged in.
// The longer term solution is to move our ModalManager into the React tree to inherit contexts properly.
return MatrixClientPeg.get()!;
}

private onKeyDown = (e: KeyboardEvent | React.KeyboardEvent): void => {
Expand Down
3 changes: 2 additions & 1 deletion tsconfig.json
Original file line number Diff line number Diff line change
Expand Up @@ -7,7 +7,7 @@
"module": "commonjs",
"moduleResolution": "node",
"target": "es2016",
"noImplicitAny": false,
"noImplicitAny": true,
"noUnusedLocals": true,
"sourceMap": false,
"outDir": "./lib",
Expand All @@ -16,6 +16,7 @@
"lib": ["es2020", "dom", "dom.iterable"],
"alwaysStrict": true,
"strictBindCallApply": true,
"strictNullChecks": true,
"noImplicitThis": true
},
"include": [
Expand Down