This repository has been archived by the owner on Sep 11, 2024. It is now read-only.
Conform more of the codebase to strictNullChecks #10672
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
t3chguy
added
the
T-Task
src/utils/SortMembers.ts
Outdated
| @@ -96,13 +97,14 @@ interface IMemberScore { | |||
| numRooms: number; | |||
| } | |||
|
|
|||
| export function buildMemberScores(cli: MatrixClient): { [key: string]: IMemberScore | undefined } { | |||
| export function buildMemberScores(cli: MatrixClient): { [key: string]: IMemberScore } { | |||
There was a problem hiding this comment.
Minor point - not sure if we prefer <Record<string, ...> for cases like this (also valid elsewhere in this file)
There was a problem hiding this comment.
In a case where the key string is uselessly key I agree, but IMO this form is better as the key can be given a helpful name, I'll update it to userId for self-documenting
There was a problem hiding this comment.
I'd never considered that, makes sense
Not yet, not the best way to do things but still helps the overall goal |
artcodespace
approved these changes
Apr 21, 2023
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For element-hq/element-web#21967
This change is marked as an internal change (Task), so will not be included in the changelog.