Skip to content
This repository was archived by the owner on Sep 11, 2024. It is now read-only.

Handle command completions in RTE #10521

Merged
merged 38 commits into from
Apr 10, 2023
Merged
Changes from 1 commit
Commits
Show all changes
38 commits
Select commit Hold shift + click to select a range
02939fe
pass handleCommand prop down and use it in WysiwygAutocomplete
Apr 3, 2023
d4cadad
allow a command to generate a query from buildQuery
Apr 3, 2023
4fe0077
port command functionality into the sendMessage util
Apr 3, 2023
6b623d0
tidy up comments
Apr 3, 2023
e056d5d
remove use of shouldSend and update comments
Apr 3, 2023
c0668f4
remove console log
Apr 3, 2023
212a998
make logic more explicit and amend comment
Apr 5, 2023
c65a1b7
uncomment replyToEvent block
Apr 5, 2023
f4c272d
update util test
Apr 5, 2023
6f46bf8
remove commented out test
Apr 5, 2023
0db94cb
use local text over import from current composer
Apr 5, 2023
f8bddc0
expand tests
Apr 5, 2023
735e8a8
expand tests
Apr 6, 2023
b0c62a3
handle the FocusAComposer action for the wysiwyg composer
Apr 6, 2023
86347a4
remove TODO comment
Apr 6, 2023
0282c14
remove TODO
Apr 6, 2023
377e191
test for action dispatch
Apr 6, 2023
66f8380
fix failing tests
Apr 6, 2023
8cddb25
tidy up tests
Apr 6, 2023
000d744
fix TS error and improve typing
Apr 6, 2023
a1a5917
Merge remote-tracking branch 'origin/develop' into alunturner/handle-…
Apr 6, 2023
b1ca999
fix TS error
Apr 6, 2023
4abd905
amend return types for sendMessage, editMessage
Apr 6, 2023
fa13702
fix null content TS error
Apr 6, 2023
01fa6a7
fix another null content TS error
Apr 6, 2023
cd4ce1b
use as to correct final TS error
Apr 6, 2023
63579d0
Merge branch 'develop' into alunturner/handle-command-completions
Apr 6, 2023
45cc670
remove undefined argument
Apr 6, 2023
b77025b
try to fix TS errors for editMessage function usage
Apr 6, 2023
91ba491
Merge remote-tracking branch 'origin/develop' into alunturner/handle-…
Apr 6, 2023
2863b3d
tidy up
Apr 6, 2023
61946a1
add TODO
Apr 6, 2023
a72b837
Merge remote-tracking branch 'origin/develop' into alunturner/handle-…
Apr 6, 2023
276f4f7
improve comments
Apr 6, 2023
425d946
Merge branch 'develop' into alunturner/handle-command-completions
artcodespace Apr 6, 2023
eb4e1a8
update comment
Apr 10, 2023
c08290f
Merge remote-tracking branch 'origin/develop' into alunturner/handle-…
Apr 10, 2023
b523ef7
Merge branch 'develop' into alunturner/handle-command-completions
Apr 10, 2023
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
handle the FocusAComposer action for the wysiwyg composer
  • Loading branch information
Alun Turner committed Apr 6, 2023
commit b0c62a3e495c5a4687e5aa005147855350c0377b
Original file line number Diff line number Diff line change
Expand Up @@ -46,6 +46,7 @@ export function useWysiwygSendActionHandler(

switch (payload.action) {
case "reply_to_event":
case Action.FocusAComposer:
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is the action that is fired when a user enters a bad command and then makes a decision from the dialog they're presented with - it ensures that we put the cursor back in the composer when the dialog closes.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is that documented in the actions file? Would be good to if not

case Action.FocusSendMessageComposer:
focusComposer(composerElement, context, roomContext, timeoutId);
break;
Expand Down