Remove support for unstable private read receipts (#9225)

matrix-org · Sep 12, 2022 · 28a418d · 28a418d
1 parent e52ef45
commit 28a418d
Show file tree

Hide file tree

Showing 2 changed files with 6 additions and 6 deletions.
diff --git a/src/components/structures/TimelinePanel.tsx b/src/components/structures/TimelinePanel.tsx
@@ -30,7 +30,6 @@ import { ClientEvent } from "matrix-js-sdk/src/client";
 import { Thread } from 'matrix-js-sdk/src/models/thread';
 import { ReceiptType } from "matrix-js-sdk/src/@types/read_receipts";
 import { MatrixError } from 'matrix-js-sdk/src/http-api';
-import { getPrivateReadReceiptField } from "matrix-js-sdk/src/utils";
 
 import SettingsStore from "../../settings/SettingsStore";
 import { Layout } from "../../settings/enums/Layout";
@@ -983,13 +982,15 @@ class TimelinePanel extends React.Component<IProps, IState> {
             ).catch(async (e) => {
                 // /read_markers API is not implemented on this HS, fallback to just RR
                 if (e.errcode === 'M_UNRECOGNIZED' && lastReadEvent) {
-                    const privateField = await getPrivateReadReceiptField(MatrixClientPeg.get());
-                    if (!sendRRs && !privateField) return;
+                    if (
+                        !sendRRs
+                        && !MatrixClientPeg.get().doesServerSupportUnstableFeature("org.matrix.msc2285.stable")
+                    ) return;
 
                     try {
                         return await MatrixClientPeg.get().sendReadReceipt(
                             lastReadEvent,
-                            sendRRs ? ReceiptType.Read : privateField,
+                            sendRRs ? ReceiptType.Read : ReceiptType.ReadPrivate,
                         );
                     } catch (error) {
                         logger.error(e);

diff --git a/src/components/views/settings/tabs/user/PreferencesUserSettingsTab.tsx b/src/components/views/settings/tabs/user/PreferencesUserSettingsTab.tsx
@@ -127,8 +127,7 @@ export default class PreferencesUserSettingsTab extends React.Component<IProps,
     public async componentDidMount(): Promise<void> {
         this.setState({
             disablingReadReceiptsSupported: (
-                await MatrixClientPeg.get().doesServerSupportUnstableFeature("org.matrix.msc2285.stable") ||
-                await MatrixClientPeg.get().doesServerSupportUnstableFeature("org.matrix.msc2285")
+                await MatrixClientPeg.get().doesServerSupportUnstableFeature("org.matrix.msc2285.stable")
             ),
         });
     }