Clean up legacy stores #4663
Merged
Clean up legacy stores #4663
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The rust cryto needs these legacy stores in order to do the migration from the legacy crypto to the rust crypto. We keep the following methods of the stores: - Used in `libolm_migration.ts`. - Needed in the legacy store tests. - Needed in the rust crypto test migration.
In order to be able to delete the legacy crypto, these stores shouldn't rely on the legacy crypto. We need to extract the used types.
florianduros
merged commit 344ffa3
into
florianduros/rip-out-legacy-crypto/remove-legacy-crypto
15 of 24 checks passed
florianduros
deleted the
florianduros/rip-out-legacy-crypto/clean-up-store
branch
florianduros
added a commit
that referenced
this pull request
Jan 31, 2025
In #4663, the storeXXX methods were removed of the CryptoStore interface but they are used internally by IndexedDBCryptoStore.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Task element-hq/element-web#26922
Part of #4653
The migration from the legacy crypto to the rust crypto uses the legacy stores. In order to be able to delete the rest of the legacy crypto, these stores shouldn't rely on the types of the legacy crypto.
This PR does:
src/crypto/store/base.tsThe legacy crypto tests and linting are in failure due to the removal of the store methods. The legacy crypto will be removed in the next PR.