Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Revert "Distinguish room state and timeline events in embedded clients (#4574)" #4656

Merged
merged 1 commit into from
Jan 27, 2025
Merged

Revert "Distinguish room state and timeline events in embedded clients (#4574)" #4656

merged 1 commit into from
Jan 27, 2025

Conversation

hughns
Copy link
Member

@hughns hughns commented Jan 24, 2025 •
edited
Loading

Fixes #4655

This reverts commit bdd4d82.

Checklist

  • Tests written for new code (and old code if feasible).
  • New or updated public/exported symbols have accurate TSDoc documentation.
  • Linter and other CI checks pass.
  • Sign-off given on the changes (see CONTRIBUTING.md).

@hughns hughns added T-Defect backport staging Label to automatically backport PR to staging branch labels Jan 24, 2025
@hughns hughns marked this pull request as ready for review January 27, 2025 09:50
@hughns hughns requested review from a team as code owners January 27, 2025 09:50
@hughns hughns requested review from dbkr and florianduros January 27, 2025 09:50
@hughns hughns added this pull request to the merge queue Jan 27, 2025
Merged via the queue into develop with commit fd9a44e Jan 27, 2025
45 checks passed
@hughns hughns deleted the hughns/revert-#4574 branch January 27, 2025 10:27
RiotRobot pushed a commit that referenced this pull request Jan 27, 2025
@hughns @github-actions
Revert "Distinguish room state and timeline events in embedded clients (
d9d4380 
#4574)" (#4656)

This reverts commit bdd4d82.

(cherry picked from commit fd9a44e)
@RiotRobot RiotRobot mentioned this pull request Jan 27, 2025
Merged
t3chguy pushed a commit that referenced this pull request Jan 27, 2025
@RiotRobot @hughns
Revert "Distinguish room state and timeline events in embedded clients (
e4590ca 
#4574)" (#4656) (#4657)

Co-authored-by: Hugh Nimmo-Smith <[email protected]>
@hughns hughns mentioned this pull request Jan 27, 2025
Draft
4 tasks
toger5 added a commit that referenced this pull request Jan 27, 2025
@toger5
Reapply "Distinguish room state and timeline events in embedded clien…
b595396 
…ts (#4574)" (#4656)

This reverts commit fd9a44e.
@hughns hughns mentioned this pull request Jan 29, 2025
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@florianduros florianduros florianduros approved these changes

@dbkr dbkr Awaiting requested review from dbkr dbkr is a code owner automatically assigned from matrix-org/element-web-team

Assignees
No one assigned
Labels
backport staging Label to automatically backport PR to staging branch T-Defect X-Release-Blocker
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Regression: Embedded mode no longer works with widget host that does not support update_state action
3 participants
@hughns @florianduros @t3chguy