Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove deprecated DeviceInfo in webrtc/call.ts #4654

Merged
merged 2 commits into from
Jan 27, 2025
Merged

Remove deprecated DeviceInfo in webrtc/call.ts #4654

merged 2 commits into from
Jan 27, 2025

Conversation

florianduros
Copy link
Contributor

@florianduros florianduros commented Jan 23, 2025 •
edited
Loading

Checklist

  • Tests written for new code (and old code if feasible).
  • New or updated public/exported symbols have accurate TSDoc documentation.
  • Linter and other CI checks pass.
  • Sign-off given on the changes (see CONTRIBUTING.md).

Task element-hq/element-web#26922
Part of #4653

The deprecated DeviceInfo was set into opponentDeviceInfo however opponentDeviceInfo was only used for boolean operations. We can replace it with a boolean attribute.

@florianduros florianduros changed the base branch from develop to florianduros/rip-out-legacy-crypto/remove-legacy-crypto January 23, 2025 18:00
@florianduros florianduros added the T-Task Tasks for the team like planning label Jan 23, 2025
@florianduros florianduros mentioned this pull request Jan 23, 2025
Draft
4 tasks
@florianduros florianduros marked this pull request as ready for review January 23, 2025 18:07
@florianduros florianduros requested a review from a team as a code owner January 23, 2025 18:07
@florianduros florianduros requested review from hughns and removed request for a team January 23, 2025 18:07
@florianduros florianduros changed the title Remove deprecated DeviceInfo in call.ts Remove deprecated DeviceInfo in webrtc/call.ts Jan 27, 2025
AndrewFerr
AndrewFerr reviewed Jan 27, 2025
View reviewed changes
src/webrtc/call.ts Outdated Show resolved Hide resolved
@florianduros florianduros merged commit f763192 into florianduros/rip-out-legacy-crypto/remove-legacy-crypto Jan 27, 2025
27 checks passed
@florianduros florianduros deleted the florianduros/rip-out-legacy-crypto/call-deviceinfo branch January 27, 2025 14:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@AndrewFerr AndrewFerr AndrewFerr approved these changes

@hughns hughns Awaiting requested review from hughns hughns is a code owner automatically assigned from matrix-org/element-call-reviewers

Assignees
No one assigned
Labels
T-Task Tasks for the team like planning
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@florianduros @AndrewFerr