Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Trigger call rejoin attempt only if you were in it #4524

Draft
wants to merge 2 commits into
base: develop
Choose a base branch
from
Draft

Trigger call rejoin attempt only if you were in it #4524

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
8321695
Trigger call rejoin attempt only if you were in it
AndrewFerr Nov 12, 2024
d48ee92
Add comments
AndrewFerr Nov 12, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 6 additions & 1 deletion src/matrixrtc/MatrixRTCSession.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -871,7 +871,12 @@ export class MatrixRTCSession extends TypedEventEmitter<MatrixRTCSessionEvent, M
logger.info(`Memberships for call in room ${this.room.roomId} have changed: emitting`);
this.emit(MatrixRTCSessionEvent.MembershipsChanged, oldMemberships, this.memberships);

if (this.isJoined() && !this.memberships.some(this.isMyMembership)) {
if (
this.isJoined() && // we mean to be joined
oldMemberships.some(this.isMyMembership) && // prior state says we were joined
!this.memberships.some(this.isMyMembership) // current says we are not joined
) {
// State says that we left, but we still mean to be joined
logger.warn("Missing own membership: force re-join");
// TODO: Should this be awaited? And is there anything to tell the focus?
this.triggerCallMembershipEventUpdate();
Expand Down