Element-R: Implement VerificationRequest.{timeout,pending}
#3532
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
richvdh
commented
Jun 29, 2023
| @@ -55,7 +55,7 @@ | |||
| ], | |||
| "dependencies": { | |||
| "@babel/runtime": "^7.12.5", | |||
| "@matrix-org/matrix-sdk-crypto-js": "^0.1.0-alpha.11", | |||
| "@matrix-org/matrix-sdk-crypto-js": "^0.1.0", | |||
There was a problem hiding this comment.
v0.1.0 adds timeRemainingMillis
richvdh
added
T-Enhancement
T-Task
richvdh
force-pushed
the
rav/element-r/35_verification_request_methods
branch
from
0b2fc15 to
59f5728
Compare
richvdh
requested review from
justjanne and
andybalaam
and removed request for
a team
justjanne
approved these changes
Jun 29, 2023
richvdh
force-pushed
the
rav/element-r/33_accept_request
branch
from
7a1ddec to
1b8c1ca
Compare
richvdh
force-pushed
the
rav/element-r/35_verification_request_methods
branch
from
59f5728 to
5c99c48
Compare
This was referenced Jun 30, 2023
richvdh
force-pushed
the
rav/element-r/35_verification_request_methods
branch
from
5c99c48 to
283a08a
Compare
* Rust crypto: allow using a memory store It turns out that, for some usecases (in particular, "bot users" for cypress tests), we don't need persistent storage and an in-memory store will be fine. * Rust crypto: use a memory store for the unit tests
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A couple of little methods on
VerificationRequestPart of element-hq/element-web#25320
Based on #3526
This change is marked as an internal change (Task), so will not be included in the changelog.