Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump version of the react-sdk cypress workflow file #3501

Merged
merged 2 commits into from
Jun 26, 2023

Conversation

richvdh
Copy link
Member

@richvdh richvdh commented Jun 23, 2023

cypress.yaml is currently pinned to an old version of the react-sdk, meaning that each attempt to run it is currently failing with an error.

(See https://github.com/matrix-org/matrix-js-sdk/actions/runs/5355422916:

The workflow is not valid. .github/workflows/cypress.yml (Line: 27, Col: 28): Invalid secret, TCMS_USERNAME is not defined in the referenced workflow. .github/workflows/cypress.yml (Line: 28, Col: 28): Invalid secret, TCMS_PASSWORD is not defined in the referenced workflow.

)

(Introduced by #3480)


This change is marked as an internal change (Task), so will not be included in the changelog.

`cypress.yaml` is currently pinned to an old version of the react-sdk, meaning
that each attempt to run it is currently failing with an error.

(Introduced by #3480)
@richvdh richvdh added the T-Task Tasks for the team like planning label Jun 23, 2023
@richvdh richvdh marked this pull request as ready for review June 23, 2023 11:03
@richvdh richvdh requested a review from a team as a code owner June 23, 2023 11:03
@richvdh richvdh requested a review from germain-gg June 23, 2023 11:03
@t3chguy
Copy link
Member

t3chguy commented Jun 26, 2023

Looks like this is handled as part of #3467

@richvdh richvdh added this pull request to the merge queue Jun 26, 2023
Merged via the queue into develop with commit 3e646bd Jun 26, 2023
@richvdh richvdh deleted the rav/bump_react_sdk_version branch June 26, 2023 09:25
@richvdh
Copy link
Member Author

richvdh commented Jun 26, 2023

Gah. this didn't fix the problem, because the change needed in the react-sdk (matrix-org/matrix-react-sdk#11069) didn't actually land in v3.74.0.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
T-Task Tasks for the team like planning
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants