Don't allow user to unmute if another user is speaking #2313
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
on sender side by muting mic after the max transmit time has elapsed.
…_other_user_speaking
…_other_user_speaking
germain-gg
approved these changes
Apr 22, 2022
| // if anoher user is currently unmuted, we can't unmute | ||
| if (!muted && this.userMediaFeeds.some(f => !f.isAudioMuted())) { | ||
| throw new OtherUserSpeakingError(); | ||
| } |
There was a problem hiding this comment.
This seems susceptible to ping response time races? If multiple people unmute at the same time, they all would be allowed.
| @@ -408,6 +414,12 @@ export class GroupCall extends EventEmitter { | |||
|
|
|||
| // set a timer for the maximum transmit time on PTT calls | |||
| if (this.isPtt) { | |||
| // if anoher user is currently unmuted, we can't unmute | |||
There was a problem hiding this comment.
This seems a bit weird to force on everyone.
If I was using this for game callouts, I would want to interrupt the other person.
dbkr
added a commit
that referenced
this pull request
May 3, 2022
* Add PTT call mode & mute by default in PTT calls (#2311) No other parts of PTT calls implemented yet * Make the tests pass again (#2316) 3280394 made call use a bunch of methods that weren't mocked in the tests. * Add maximum trasmit time for PTT (#2312) on sender side by muting mic after the max transmit time has elapsed. * Don't allow user to unmute if another user is speaking (#2313) * Add maximum trasmit time for PTT on sender side by muting mic after the max transmit time has elapsed. * Don't allow user to unmute if another user is speaking Based on #2312 For element-hq/element-call#298 * Fix createGroupCall arguments (#2325) Comma instead of a colon...
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Based on #2312
For element-hq/element-call#298
Here's what your changelog entry will look like:
✨ Features