Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

MSC2002: Proposal for adopting MSC1884 as v4 rooms #2002

Merged
merged 7 commits into from
May 21, 2019
Merged

MSC2002: Proposal for adopting MSC1884 as v4 rooms #2002

merged 7 commits into from
May 21, 2019

Conversation

ara4n
Copy link
Member

@ara4n ara4n commented May 17, 2019 •
edited by richvdh
Loading

@ara4n ara4n added the proposal A matrix spec change proposal label May 17, 2019
@turt2live turt2live mentioned this pull request May 17, 2019
Closed
@turt2live turt2live changed the title proposal for adopting MSC1884 as v4 rooms MSC2002: Proposal for adopting MSC1884 as v4 rooms May 17, 2019
Cadair
Cadair reviewed May 19, 2019
View reviewed changes
@ara4n
Copy link
Member Author

ara4n commented May 20, 2019

@mscbot fcp merge

we want to get this and 1884 merged asap and released in prep for 1.0

@mscbot
Copy link
Collaborator

mscbot commented May 20, 2019 •
edited by ara4n
Loading

Team member @ara4n has proposed to merge this. The next step is review by the rest of the tagged people:

No concerns currently listed.

Once a majority of reviewers approve (and none object), this will enter its final comment period. If you spot a major issue that hasn't been raised at any point in this process, please speak up!

See this document for info about what commands tagged team members can give me.

@mscbot mscbot added proposed-final-comment-period Currently awaiting signoff of a majority of team members in order to enter the final comment period. disposition-merge labels May 20, 2019
@anoadragon453
Copy link
Member

#1884 - link for the lazy

@richvdh
Copy link
Member

richvdh commented May 20, 2019

I think what happens for room v5 / matrix 1.0 and beyond are somewhat orthogonal here. +1 to getting features out into the wild rather than sitting on them until they form a huge batch, so I am happy with this.

@mscbot mscbot added final-comment-period This MSC has entered a final comment period in interest to approval, postpone, or delete in 5 days. and removed proposed-final-comment-period Currently awaiting signoff of a majority of team members in order to enter the final comment period. labels May 20, 2019
@mscbot
Copy link
Collaborator

mscbot commented May 20, 2019

🔔 This is now entering its final comment period, as per the review above. 🔔

@ara4n
Copy link
Member Author

ara4n commented May 20, 2019

I think what happens for room v5 / matrix 1.0 and beyond are somewhat orthogonal here.

I think the proposed longer-term context is fairly important to try to understand how this fits in, but agreed it's technically orthogonal to the MSC itself.

@ara4n
Copy link
Member Author

ara4n commented May 20, 2019

@matrix-org/core-team I'd like to propose an expedited FCP for this, so we can merge this (and #1884) into the spec and ship it in synapse (matrix-org/synapse#5210) asap, so that when 1.0 rolls around we have as many servers talking v4 rooms in the wild as possible and we can enable creating v4 rooms by default.

I suggest we reduce FCP to 1 day - i.e. aim to merge this around 15:00 GMT+1 tomorrow, unless someone finds a last minute problem with MSC1884 (or this).

@ara4n ara4n mentioned this pull request May 20, 2019
Closed
richvdh added a commit to matrix-org/synapse that referenced this pull request May 21, 2019
@richvdh
Introduce room v4 which updates event ID format.
cba5bbd 
Implements matrix-org/matrix-spec-proposals#2002.
@richvdh richvdh mentioned this pull request May 21, 2019
Merged
@richvdh
Copy link
Member

richvdh commented May 21, 2019

Impl is at matrix-org/synapse#5217, ready to merge when this completes FCP.

@richvdh
Copy link
Member

richvdh commented May 21, 2019

as per #2002 (comment), we are declaring FCP to be complete here.

@richvdh
Copy link
Member

richvdh commented May 21, 2019

cancelling the bot's FCP to stop it "helping"

@mscbot fcp cancel

@mscbot
Copy link
Collaborator

mscbot commented May 21, 2019

@richvdh proposal cancelled.

@mscbot mscbot removed final-comment-period This MSC has entered a final comment period in interest to approval, postpone, or delete in 5 days. disposition-merge labels May 21, 2019
@richvdh richvdh merged commit 3787110 into master May 21, 2019
@richvdh richvdh added spec-pr-missing Proposal has been implemented and is being used in the wild but hasn't yet been added to the spec and removed proposal-in-review labels May 21, 2019
richvdh added a commit to matrix-org/synapse that referenced this pull request May 21, 2019
@richvdh
Introduce room v4 which updates event ID format. (#5217)
17f6804 
Implements matrix-org/matrix-spec-proposals#2002.
@turt2live turt2live self-assigned this May 24, 2019
@turt2live turt2live mentioned this pull request May 24, 2019
Merged
@turt2live
Copy link
Member

Spec PR: #2019

@turt2live turt2live added spec-pr-in-review A proposal which has been PR'd against the spec and is in review and removed spec-pr-missing Proposal has been implemented and is being used in the wild but hasn't yet been added to the spec labels May 24, 2019
turt2live added a commit that referenced this pull request May 28, 2019
@turt2live
Add version 4 rooms to the spec
3b0e194 
As per [MSC1884](#1884) and [MSC2002](#2002).

No known changes since the proposals were accepted.

Due to being in the area: This fixes #1863
@turt2live
Copy link
Member

merged 🎉

@turt2live turt2live added merged A proposal whose PR has merged into the spec! and removed spec-pr-in-review A proposal which has been PR'd against the spec and is in review labels May 28, 2019
turt2live added a commit that referenced this pull request Jun 6, 2019
@turt2live
Make v4 the "default" room version
80aa5a2 
As per [MSC2002](#2002). This was missed in #2019

Fixes #2071
@turt2live turt2live mentioned this pull request Jun 6, 2019
Merged
@turt2live turt2live added the kind:core MSC which is critical to the protocol's success label Apr 20, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@turt2live turt2live turt2live left review comments

@Cadair Cadair Cadair left review comments

@KitsuneRal KitsuneRal KitsuneRal approved these changes

Assignees

@turt2live turt2live

Labels
kind:core MSC which is critical to the protocol's success merged A proposal whose PR has merged into the spec! proposal A matrix spec change proposal
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
7 participants
@ara4n @mscbot @anoadragon453 @richvdh @turt2live @Cadair @KitsuneRal