Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Track a slightly fresher fork of better-discord.js #858

Merged
merged 1 commit into from
Nov 3, 2022

Conversation

tadzik
Copy link
Contributor

@tadzik tadzik commented Oct 7, 2022

This fixes a crash related to voice channel message handling.

@tadzik tadzik requested a review from a team as a code owner October 7, 2022 08:34
Copy link
Contributor

@Half-Shot Half-Shot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems good, changelog please :)

@tadzik tadzik force-pushed the tadzik/update-dependencies branch from 73b95f6 to d7c33d5 Compare October 7, 2022 08:36
@FSG-Cat
Copy link

FSG-Cat commented Oct 7, 2022

If I may ask why are we switching to a branch that is a a single commit ahead? Isn't it a better idea to then climb up the tree to discordjs main if we want a more updated version?

@Half-Shot
Copy link
Contributor

Hiya @FSG-Cat, it's a good point:

We're updating to fix a specific bug, and are considering updating to stock in the future. It would take considerable effort to refactor the bridge for the moment, so we want to ensure we fix the more pressing bug, then circle back to refactoring later :)

Thanks for raising it!

@Miepee
Copy link
Contributor

Miepee commented Oct 7, 2022

Which bug was it? If it's user facing, maybe mention that in the changelog as well?

@FSG-Cat
Copy link

FSG-Cat commented Oct 7, 2022

Hiya @FSG-Cat, it's a good point:

We're updating to fix a specific bug, and are considering updating to stock in the future. It would take considerable effort to refactor the bridge for the moment, so we want to ensure we fix the more pressing bug, then circle back to refactoring later :)

Thanks for raising it!

Thanks for the information.

@turt2live
Copy link
Member

uh, you should be able to switch to upstream.

@erkinalp
Copy link

erkinalp commented Oct 9, 2022

alternative: switch to fosscord.js which is a fork of discord.js with third party instance support.

@tadzik tadzik force-pushed the tadzik/update-dependencies branch from c1a17ee to b030e9e Compare November 3, 2022 09:21
@tadzik tadzik changed the title Switch to t2bot's fork of better-discord.js Track a slightly fresher fork of better-discord.js Nov 3, 2022
@tadzik
Copy link
Contributor Author

tadzik commented Nov 3, 2022

I clarified the issue in both the commit message and the changelog.

The switch to upstream discord/fosscord.js is very much on our radar, but given how far behind we are and all the API changes that happened in the upstream since the version we're on, this is a significantly bigger effort that'll take us a while to complete.

This is a hotfix to fix a voice-channel related crash, just to improve the stability of the bridge while the proper upstream sync is still brewing.

This fixes a crash related to voice channel message handling.
@tadzik tadzik force-pushed the tadzik/update-dependencies branch from b030e9e to c8787d2 Compare November 3, 2022 09:25
@tadzik tadzik merged commit ffa0f22 into develop Nov 3, 2022
@tadzik tadzik deleted the tadzik/update-dependencies branch November 3, 2022 09:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants