-
Notifications
You must be signed in to change notification settings - Fork 153
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Track a slightly fresher fork of better-discord.js #858
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Seems good, changelog please :)
73b95f6
to
d7c33d5
Compare
If I may ask why are we switching to a branch that is a a single commit ahead? Isn't it a better idea to then climb up the tree to discordjs main if we want a more updated version? |
Hiya @FSG-Cat, it's a good point: We're updating to fix a specific bug, and are considering updating to stock in the future. It would take considerable effort to refactor the bridge for the moment, so we want to ensure we fix the more pressing bug, then circle back to refactoring later :) Thanks for raising it! |
Which bug was it? If it's user facing, maybe mention that in the changelog as well? |
Thanks for the information. |
uh, you should be able to switch to upstream. |
alternative: switch to fosscord.js which is a fork of discord.js with third party instance support. |
c1a17ee
to
b030e9e
Compare
I clarified the issue in both the commit message and the changelog. The switch to upstream discord/fosscord.js is very much on our radar, but given how far behind we are and all the API changes that happened in the upstream since the version we're on, this is a significantly bigger effort that'll take us a while to complete. This is a hotfix to fix a voice-channel related crash, just to improve the stability of the bridge while the proper upstream sync is still brewing. |
This fixes a crash related to voice channel message handling.
b030e9e
to
c8787d2
Compare
This fixes a crash related to voice channel message handling.