Skip to content

Commit

Permalink
Add pull request template
Browse files Browse the repository at this point in the history
  • Loading branch information
Half-Shot committed May 19, 2022
1 parent 5be7813 commit 7686e71
Show file tree
Hide file tree
Showing 2 changed files with 3 additions and 1 deletion.
3 changes: 3 additions & 0 deletions .github/pull_request_template.md
Original file line number Diff line number Diff line change
@@ -0,0 +1,3 @@
<!-->
Hi there 👋, please check you've read the [CONTRIBUTING](../CONTRIBUTING.md) guide before submitting a PR (it's worth it, honest).
<-->
1 change: 0 additions & 1 deletion CONTRIBUTING.md
Original file line number Diff line number Diff line change
Expand Up @@ -77,7 +77,6 @@ pass CI when reviewing too. If you can't get the CI to pass, please reach out to

When making a pull request, please be aware of these best practises.

- **Importantly**:
- Targets `develop` (unless it explicitly depends upon another feature, then depend on that branch and comment to that effect in the PR body).
- Is updated via rebase mechanisms when `develop` changes, rather than merge commits (reduces noise).
- Is [signed off](https://matrix-org.github.io/synapse/latest/development/contributing_guide.html#sign-off).
Expand Down

0 comments on commit 7686e71

Please sign in to comment.