Add a partial to download the assets from CDNs #4
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Kévin Commaille <[email protected]>
Signed-off-by: Kévin Commaille <[email protected]>
zecakeh
changed the title
|
To see the differences with upstream: google/docsy@v0.8.0...zecakeh:matrix-org-docsy:cdn-shortcode. |
|
Another nice thing that this adds is that the assets will only be bundled if we need them. So currently we only download jQuery with the spec. |
This was referenced Oct 24, 2024
Merged
Merged
richvdh
reviewed
Oct 29, 2024
Signed-off-by: Kévin Commaille <[email protected]>
richvdh
approved these changes
Oct 30, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Instead of downloading them manually when upgrading the theme.
This should be reviewed by commit, the first one resets the modified files to their version upstream so the changes in the second commit are cleaner.