Skip to content
This repository has been archived by the owner on Nov 25, 2024. It is now read-only.

Implement pushrules API #884

Closed
wants to merge 4 commits into from
Closed

Conversation

prateek2211
Copy link
Contributor

Signed-off-by: Prateek Sachan [email protected]

Pull Request Checklist

  • Implements GET /_matrix/client/r0/pushrules/
  • Implements /_matrix/client/r0/pushrules/{scope}/{kind}/{ruleId}
  • I have added any new tests that need to pass to testfile as specified in docs/sytest.md
  • Pull request includes a sign off

@kegsay
Copy link
Member

kegsay commented Apr 15, 2020

We may want to implement push as a different component c.f #481 (comment) - we need to think about this a bit more to work out if that is a sensible approach.

As such, I think this PR is a little premature sadly. Closing this - we may take inspiration from this PR when we get around to implementing push.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants