Switch the default config option values for recaptcha_sitekey_class and recaptcha_form_field

[anoadragon453]

Attempting to use the web auth fallback mechanism for Google ReCAPTCHA with the default setting for client_api.recaptcha_sitekey_class of "g-recaptcha-response" results in no captcha being rendered:

I cross-checked the captcha code between dendrite.matrix.org's fallback page and matrix-client.matrix.org's one (which both use the same captcha public key) and noticed a discrepancy in the class attribute of the div that renders the captcha. ReCAPTCHA's docs state to use "g-recaptcha" as the class for the submit button.

I noticed this when user @parappanon:parappa.party reported that they were also seeing no captcha being rendered on their Dendrite instance. Changing client_api.recaptcha_sitekey_class to "g-recaptcha" caused their captcha to render properly as well.

There may have been a change in the class name from ReCAPTCHA v2 to v3? The docs for v2 also request one uses "g-recaptcha" though.

Thus I propose changing the default setting to unbreak people's recaptcha auth fallback pages. Should fix dendrite.matrix.org as well.

[codecov]

Codecov Report

Base: 36.56% // Head: 36.60% // Increases project coverage by +0.04% 🎉

Coverage data is based on head (697403b) compared to base (477a44f).
Patch coverage: 100.00% of modified lines in pull request are covered.

Additional details and impacted files

@@            Coverage Diff             @@
##             main    #2939      +/-   ##
==========================================
+ Coverage   36.56%   36.60%   +0.04%     
==========================================
  Files         494      494              
  Lines       54676    54676              
==========================================
+ Hits        19993    20016      +23     
+ Misses      32114    32098      -16     
+ Partials     2569     2562       -7     

Flag	Coverage Δ
unittests	36.60% <100.00%> (+0.04%)	⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files	Coverage Δ
setup/config/config_clientapi.go	73.13% <100.00%> (ø)
syncapi/streams/stream_pdu.go	30.98% <0.00%> (-0.24%)	⬇️
roomserver/internal/query/query.go	25.79% <0.00%> (+0.43%)	⬆️
roomserver/storage/shared/storage.go	45.45% <0.00%> (+0.56%)	⬆️
userapi/storage/postgres/account_data_table.go	82.69% <0.00%> (+1.92%)	⬆️
userapi/consumers/roomserver.go	43.38% <0.00%> (+2.37%)	⬆️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

[anoadragon453]

@S7evinK I've updated this PR to also change the default of the client_api.recaptcha_form_field option. My theory is that the default values for the recaptcha_sitekey_class and recaptcha_form_field options were accidentally swapped.

[anoadragon453]

@S7evinK CI failures appear unrelated to the PR. Also heads up I don't have perms to merge this PR, if you're waiting on me to do so :)

[S7evinK]

Yep, they are related to matrix-org/complement@8550c22 I think (at least for Complement)