Skip to content
This repository has been archived by the owner on Nov 25, 2024. It is now read-only.

Implement push notifications #611

Closed
4 tasks
babolivier opened this issue Jan 8, 2019 · 3 comments · Fixed by #1842
Closed
4 tasks

Implement push notifications #611

babolivier opened this issue Jan 8, 2019 · 3 comments · Fixed by #1842
Labels
are-we-synapse-yet This issue or PR involves Sytests in AWSY new-endpoints Issue is about implementing endpoints that aren't supported by Dendrite yet

Comments

@babolivier
Copy link
Contributor

A good way to implement this module would be to create a new dedicated component (instead of shoving it into the clientapi one) which would consume events from the roomserver's output Kafka stream.

@babolivier babolivier added the new-endpoints Issue is about implementing endpoints that aren't supported by Dendrite yet label Jan 8, 2019
@babolivier babolivier added p2 and removed p2 labels Jan 8, 2019
@kegsay kegsay removed the p2 label Apr 15, 2020
@kegsay
Copy link
Member

kegsay commented Aug 24, 2020

Sytests:

    × Pushers created with a different access token are deleted on password change
    × Pushers created with a the same access token are not deleted on password change
    × Test that a message is pushed
    × Invites are pushed
    × Rooms with names are correctly named in pushes
    × Rooms with canonical alias are correctly named in pushed
    × Rooms with many users are correctly pushed
    × Don't get pushed for rooms you've muted
    × Rejected events are not pushed
    × Can add global push rule for room
    × Can add global push rule for sender
    × Can add global push rule for content
    × Can add global push rule for override
    × Can add global push rule for underride
    × New rules appear before old rules by default
    × Can add global push rule before an existing rule
    × Can add global push rule after an existing rule
    × Can delete a push rule
    × Can disable a push rule
    × Adding the same push rule twice is idempotent
    × Messages that notify from another user increment notification_count
    × Messages that org.matrix.msc2625.mark_unread from another user increment org.matrix.msc2625.unread_count
    × Messages that highlight from another user increment unread highlight count
    × Can change the actions of default rules
    ✓ Changing the actions of an unknown default rule fails with 404
    × Can change the actions of a user specified rule
    ✓ Changing the actions of an unknown rule fails with 404
    × Can fetch a user's pushers
    ✓ Push rules come down in an initial /sync
    × Adding a push rule wakes up an incremental /sync
    × Disabling a push rule wakes up an incremental /sync
    × Enabling a push rule wakes up an incremental /sync
    × Setting actions for a push rule wakes up an incremental /sync
    × Can enable/disable default rules
    ✓ Enabling an unknown default rule fails with 404
    × Test that rejected pushers are removed.
    × Notifications can be viewed with GET /notifications
    × Trying to add push rule with no scope fails with 400
    × Trying to add push rule with invalid scope fails with 400
    × Trying to add push rule with missing template fails with 400
    × Trying to add push rule with missing rule_id fails with 400
    × Trying to add push rule with empty rule_id fails with 400
    × Trying to add push rule with invalid template fails with 400
    × Trying to add push rule with rule_id with slashes fails with 400
    × Trying to add push rule with override rule without conditions fails with 400
    × Trying to add push rule with underride rule without conditions fails with 400
    × Trying to add push rule with condition without kind fails with 400
    × Trying to add push rule with content rule without pattern fails with 400
    × Trying to add push rule with no actions fails with 400
    × Trying to add push rule with invalid action fails with 400
    × Trying to add push rule with invalid attr fails with 400
    × Trying to add push rule with invalid value for enabled fails with 400
    × Trying to get push rules with no trailing slash fails with 400
    × Trying to get push rules with scope without trailing slash fails with 400
    × Trying to get push rules with template without tailing slash fails with 400
    × Trying to get push rules with unknown scope fails with 400
    × Trying to get push rules with unknown template fails with 400
    × Trying to get push rules with unknown attribute fails with 400
    ✓ Trying to get push rules with unknown rule_id fails with 404
    × Getting push rules doesn't corrupt the cache SYN-390

@kegsay kegsay added the are-we-synapse-yet This issue or PR involves Sytests in AWSY label Aug 24, 2020
@ghost ghost mentioned this issue Apr 23, 2021
6 tasks
@bronger
Copy link

bronger commented Dec 20, 2021

Is this issue the underlying cause that I cannot see any notification settings in the client?

@tommie
Copy link
Contributor

tommie commented Dec 20, 2021

Is this issue the underlying cause that I cannot see any notification settings in the client?

Likely. From what I've seen, Element Web and Android both refuse to show settings views/pages unless the server responds successfully to pushrules.

brianathere pushed a commit to HereNotThere/dendrite that referenced this issue Feb 8, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
are-we-synapse-yet This issue or PR involves Sytests in AWSY new-endpoints Issue is about implementing endpoints that aren't supported by Dendrite yet
Projects
None yet
5 participants