Add tests for /make_knock and /send_knock (same as the join counterparts) for when the federation server is in the middle of a partial join
#447
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
reivilibre
force-pushed
the
rei/frj_send_knock_during_partial_join
branch
from
ee3dc39 to
1098798
Compare
reivilibre
force-pushed
the
rei/frj_send_knock_during_partial_join
branch
from
1098798 to
d017259
Compare
reivilibre
force-pushed
the
rei/frj_send_knock_during_partial_join
branch
from
d017259 to
b196ba4
Compare
|
Taking this out of the review queue since it's been re-marked as draft. |
DMRobertson
approved these changes
Sep 5, 2022
| RoomVersion: room.Version, | ||
| KnockEvent: builder, | ||
| } | ||
| return |
There was a problem hiding this comment.
Are we implicitly returning resp, err here?
There was a problem hiding this comment.
yeah, I find this weird but Go supports this old-school Pascal-ish style of assigning to a result variable rather than returning, except the result variable's names are declared in the function declaration.
I nicked this from what was already there; it's 'not my choice' but it seems like this may be idiomatic
|
|
||
| // daniel then tries to /send_knock via the homeserver under test | ||
| knockEvent, err := makeKnockResp.KnockEvent.Build(time.Now(), gomatrixserverlib.ServerName(testServer2.ServerName()), testServer2.KeyID, testServer2.Priv, makeKnockResp.RoomVersion) | ||
| must.NotError(t, "KnockEvent.Build", err) |
There was a problem hiding this comment.
is this just shorthand for if err != nil { /* fail the test with given message */ } ?
There was a problem hiding this comment.
yeah, seems to be
// NotError will ensure `err` is nil else terminate the test with `msg`.
func NotError(t *testing.T, msg string, err error) {
t.Helper()
if err != nil {
t.Fatalf("MustNotError: %s -> %s", msg, err)
}
}
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #445.