do not automatically download lfs files when cloning/checking out #13449
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Need to modify travis-scripts to do a git lfs pull before merging this. |
|
sgiehl
requested changes
Sep 19, 2018
.travis.yml
Outdated
| @@ -86,6 +86,7 @@ before_install: | |||
|
|
|||
| install: | |||
| - git fetch -q | |||
| - git lfs pull | |||
There was a problem hiding this comment.
Any reason for adding that here globally? Wouldn't it be enough to add that to tests\travis\install_git_lfs.sh
Guess there is no use in doing that for non UI tests.
There was a problem hiding this comment.
Makes sense, will add it there.
|
UI tests are still all failing. Seems the images are not downloaded correctly. Haven't tested, but might the order of |
|
@sgiehl build is working now |
sgiehl
approved these changes
Sep 20, 2018
|
@mattab created simple dev-docs PR here: matomo-org/developer-documentation#265 |
InfinityVoid
pushed a commit
to InfinityVoid/matomo
that referenced
this pull request
Oct 11, 2018
…tomo-org#13449) * do not automatically download lfs files when cloning/checking out * Tweak screenshots readme. * Add lfs pull command. * Update submodule. * Regenerate .travis.yml. * Must use --exclude= in fetch/pull command. * Update submodule to merged master
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See git-lfs/git-lfs#2717