Skip to content

Navigation Menu

Explore
By company size
By use case
By industry
View all solutions
Topics
- AI
- DevOps
- Security
- Software Development
- View all
Explore
- GitHub Sponsors
  Fund open source developers
- The ReadME Project
  GitHub community articles
Repositories
- Enterprise platform
  AI-powered developer platform
Available add-ons
Pricing

Search code, repositories, users, issues, pull requests...

Search

Clear

Search syntax tips

Provide feedback

We read every piece of feedback, and take your input very seriously.

Include my email address so I can be contacted

Saved searches

Use saved searches to filter your results more quickly

Name

Query

To see all available qualifiers, see our documentation.

You signed in with another tab or window. Reload to refresh your session. You signed out in another tab or window. Reload to refresh your session. You switched accounts on another tab or window. Reload to refresh your session.

Dismiss alert

matomo-org / device-detector Public

Notifications You must be signed in to change notification settings
Fork 485
Star 3.2k

Code
Issues 51
Pull requests 8
Actions
Wiki
Security
Insights

Additional navigation options

Code
Issues
Pull requests
Actions
Wiki
Security
Insights

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add missing device flag #7972

Merged

liviuconcioiu merged 1 commit into master from fix7971

Jan 7, 2025

Merged

Add missing device flag #7972

liviuconcioiu merged 1 commit into master from fix7971

Jan 7, 2025

Conversation 0 Commits 1 Checks 16 Files changed

Conversation

Copy link

Member

sgiehl commented Jan 7, 2025

Description:

fixes #7971

Review

Functional review done
Potential edge cases thought about (behavior of the code with strange input, with strange internal state or possible interactions with other Matomo subsystems)
Usability review done (is anything maybe unclear or think about anything that would cause people to reach out to support)
Security review done
Wording review done
Code review done
Tests were added if useful/possible
Reviewed for breaking changes
Developer changelog updated if needed
Documentation added if needed
Existing documentation updated if needed

Sorry, something went wrong.

All reactions


          Add missing device flag

9f006f6

fixes #7971

liviuconcioiu approved these changes

View reviewed changes

liviuconcioiu merged commit 9717465 into master

16 checks passed

liviuconcioiu deleted the fix7971 branch

January 7, 2025 18:15

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

liviuconcioiu liviuconcioiu approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Missing device key in televisions yaml

2 participants

Add this suggestion to a batch that can be applied as a single commit. This suggestion is invalid because no changes were made to the code. Suggestions cannot be applied while the pull request is closed. Suggestions cannot be applied while viewing a subset of changes. Only one suggestion per line can be applied in a batch. Add this suggestion to a batch that can be applied as a single commit. Applying suggestions on deleted lines is not supported. You must change the existing code in this line in order to create a valid suggestion. Outdated suggestions cannot be applied. This suggestion has been applied or marked resolved. Suggestions cannot be applied from pending reviews. Suggestions cannot be applied on multi-line comments. Suggestions cannot be applied while the pull request is queued to merge. Suggestion cannot be applied right now. Please check back later.

Footer

© 2025 GitHub, Inc.

Footer navigation

Terms
Privacy
Security
Status
Docs
Contact

You can’t perform that action at this time.