Adds detection for Spark, Total Browser, improves detection for Belva Browser, Phoenix and rename MIUI Browser to Mi Browser #7741
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
liviuconcioiu
commented
Jul 14, 2024
liviuconcioiu
commented
- Spark - https://fastcorporate.com/
- Total Browser - https://www.totalbrowser.com/
- Mi Browser - https://trust.mi.com/docs/miui-privacy-white-paper-global/4/7
liviuconcioiu
changed the title
liviuconcioiu
changed the title
Simbiat
reviewed
Jul 18, 2024
| @@ -570,6 +570,7 @@ class Browser extends AbstractClientParser | |||
| 'LE' => 'Smart Lenovo Browser', | |||
| 'OZ' => 'Smooz', | |||
| 'SN' => 'Snowshoe', | |||
| 'K5' => 'Spark', | |||
There was a problem hiding this comment.
Googling seems to suggest that there have been only "Baidu Spark" browser (which we do have already). Is this the one or is it something different?
There was a problem hiding this comment.
Is another browser, made by https://fastcorporate.com/ - https://www.advanceduninstaller.com/Spark-e1f42f2b16bcd71251a972fdf9b3d716-application.htm
| @@ -393,7 +393,7 @@ class Browser extends AbstractClientParser | |||
| 'M3' => 'Midori Lite', | |||
| 'M6' => 'MixerBox AI', | |||
| 'MO' => 'Mobicip', | |||
| 'MU' => 'MIUI Browser', | |||
| 'MU' => 'Mi Browser', | |||
There was a problem hiding this comment.
@sgiehl Do you agree to change the name?
sanchezzzhak
approved these changes
Jul 31, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.