Fix false positives on Iron browser for Iron-model devices. #7557
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description:
Devices with "Iron" in their brand names were originally being incorrectly detected as running the Iron browser. This PR makes one of the two Iron browser regexes more strict to avoid those false positives.
The two regexes now check for either the "Chrome/" token followed by an "Iron" token or for an "Iron/" token, with the slash. There are existing test cases covering both of those cases (Chrome/ Iron case, Iron/ case). I cross-checked the patterns with https://user-agents.net/download?browser_type=browser&browser=iron to make sure there weren't any other patterns used by the Iron browser.
Review