Change Chrome Android smartphone detection to allow "Mobile" anywhere. #7556
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
On DuckDuckGo, the "DuckDuckGo/" token is inserted between "Mobile" and "Safari", which breaks the current smartphone/tablet detection. A similar situation occurs in other browsers like Avast and Puffin. This commit changes the mobile detection to accept the "Mobile" token anywhere in the user agent to account for these cases. See https://github.com/duckduckgo/Android/blob/fc6bf1db40adc92d6b15e7f333c3f5ece47569cd/user-agent/user-agent-impl/src/test/java/com/duckduckgo/user/agent/impl/UserAgentProviderTest.kt#L551-L615.
|
Could someone look at this? |
|
Yes, everything is fine, the main thing is that we do not meet a brand with |
sanchezzzhak
approved these changes
Feb 6, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description:
On DuckDuckGo, the "DuckDuckGo/" token is inserted between "Mobile" and "Safari", which breaks the current smartphone/tablet detection. A similar situation occurs in other browsers like Avast and Puffin. This PR changes the mobile detection to accept the "Mobile" token anywhere in the user agent to account for these cases.
See the DuckDuckGo user agent code for some of the expected patterns.
Review