Detect new brands: Intel, PlusStyle, New Bridge, ZIK, Famous, Facetel, HLLO, LNMBBS, Quest, SNAMI, TeachTouch, YUMKEM, TTK-TV, Emporia, GEOZON, iReplace, actiMirror #7129
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… TeachTouch, YUMKEM
sanchezzzhak
changed the title
sanchezzzhak
changed the title
…192_1 # Conflicts: # Tests/fixtures/tablet-7.yml # regexes/device/mobiles.yml
sanchezzzhak
changed the title
sanchezzzhak
changed the title
sanchezzzhak
changed the title
feat(device) detect new brand GEOZON: LTE feat(device) detect new brand iReplace: Frog One
sanchezzzhak
changed the title
sanchezzzhak
changed the title
|
is there any progress on 3-character shortcodes? |
feat(device) detect new brand BLISS: BPM9727 feat(device) detect new brand I-INN: Communicator 9.7" 3G feat(device) detect new brand Infiniton: T5 feat(device) detect new brand PAPYRE: Pad 7.1"
feat(device) detect new brand DL: Horizon Selfie feat(device) detect new brand Denali: E-Tab DT0704K08 feat(device) detect new brand DIGICOM: DTok, A10 LTE feat(device) detect new brand DreamTab: DRN-809, DRN-709 feat(device) detect new brand Envizen: ClickTab DSH18 feat(device) detect new brand JXD: S601 WiFi feat(device) detect new brand Pioneer Computers: DreamBook
feat(device) detect new brand iNo Mobile: Scout 2 feat(device) detect new brand Redway: 7
feat(device) detect new brand VALEM: Phantom Z feat(device) detect new brand OTTO: CR05 feat(device) detect new brand Raylandz: XPower P6000 feat(device) detect new brand Kenbo: O71, O61
|
@sanchezzzhak Sorry, had been quite busy the last weeks, but it's on my todo for this week |
|
@sanchezzzhak from Matomo side three letter brand codes should actually work. Not sure if we should maybe put this into at least a minor or major release, as extending the brand codes by a letter might be some sort of breaking change maybe. |
|
@sgiehl |
|
@sanchezzzhak I'll do a new release early next week and will merge this one afterwards. |
sgiehl
approved these changes
Jul 12, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description:
Please include a description of this change and which issue it fixes. If no issue exists yet please include context and what problem it solves.
Review