Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Trim MathML string before parsing it. (mathjax/MathJax#2805) #759

Merged
merged 1 commit into from
Feb 22, 2022

Conversation

dpvc
Copy link
Member

@dpvc dpvc commented Jan 18, 2022

This PR trims whitespace from the ends of the serialized MathML sting before parsing it (so that we don't get unwanted text nodes on either side that cause MathJax to indicate multiple nodes were produced).

Resolves issue mathjax/MathJax#2805.

@dpvc dpvc requested a review from zorkow January 18, 2022 14:24
Copy link
Member

@zorkow zorkow left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great PR! I used to put the trim() into our labs because I always found that error so annoying!

@dpvc dpvc merged commit f0bbcdc into develop Feb 22, 2022
@dpvc dpvc deleted the issue2805 branch February 22, 2022 13:34
@dpvc dpvc added this to the 3.2.1 milestone Feb 22, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants