Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
this PR answers the line ending problems raised in #76
As the project, and its tests, need special line ending to be green I do not think that the project can afford to introduce line ending normalization. By doing this normalization and by specifying concrete line ends where it matters the project is build-able and tests pass regardless of the configuration of line ending on the client machine that checkouts the project.
The work done:
.gitattributes
file answering the above pointsUsage:
core.autocrlf
settings value).git
directoryUsing this version you should be able to have all tests green regardless of any git settings you could use on your machine. This normalization also ensures that even if someone try to push bad line endings where not expected, then those ones will be normalized by the rules in
.gitattributes
.If requested I can squash the PR. I kept it until now with several commits to show how I ended in the final state.
readings: