Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update material-table.js to check if depreciated properties are used before issuing console.warning #823

Merged
merged 2 commits into from
Feb 1, 2024
Merged

Update material-table.js to check if depreciated properties are used before issuing console.warning #823

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
4c40a80
Update material-table.js
KippWade Jan 5, 2024
aa8b167
Merge branch 'master' into feature/warning
KippWade Jan 31, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 9 additions & 3 deletions src/material-table.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -465,9 +465,15 @@ export default class MaterialTable extends React.Component {
(a) => a.tableData.id === orderBy
);
query.orderDirection = orderDirection;
console.warn(
'Properties orderBy and orderDirection had been deprecated when remote data, please start using orderByCollection instead'
);
/**
* THIS WILL NEED TO BE REMOVED EVENTUALLY.
* Warn consumer of deprecated prop.
*/
if (query.orderDirection !== undefined || query.orderBy !== undefined) {
console.warn(
'Properties orderBy and orderDirection had been deprecated when remote data, please start using orderByCollection instead'
);
}
query.orderByCollection = orderByCollection;
this.onQueryChange(query, () => {
this.props.onOrderChange &&
Expand Down