Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

FABs don't apply disabled styles #4045

Closed
EdricChan03 opened this issue Mar 14, 2023 · 1 comment · Fixed by #4031
Closed

FABs don't apply disabled styles #4045

EdricChan03 opened this issue Mar 14, 2023 · 1 comment · Fixed by #4031
Assignees

Comments

@EdricChan03
Copy link

The FAB and FAB extended components don't appear to apply their disabled styling correctly - see my playground for an example:

Screenshot of playground website, with all button variants disabled except the FAB and extended FAB

The ripple does appear to be disabled though should I attempt to click on them.

Code for the example

<div class="flex items-center gap-3 p-6">
  <md-elevated-button label="Elevated" {disabled} />
  <md-filled-button label="Filled" {disabled} />
  <md-outlined-button label="Outlined" {disabled} />
  <md-text-button label="Text" {disabled} />
  <md-tonal-button label="Tonal" {disabled} />
  <md-fab icon="add" {disabled} />
  <md-fab-extended label="Add" icon="add" {disabled} />
</div>

Library version used: v1.0.0-pre.4

@asyncLiz
Copy link
Collaborator

FABs are not disable-able. It looks like we need to remove the disabled property from it.

@asyncLiz asyncLiz self-assigned this Mar 14, 2023
copybara-service bot pushed a commit that referenced this issue Mar 16, 2023
Fixes #4045

PiperOrigin-RevId: 517156651
copybara-service bot pushed a commit that referenced this issue Mar 16, 2023
Fixes #4045

PiperOrigin-RevId: 517156651
This was referenced Apr 10, 2023
EdricChan03 added a commit to EdricChan03/mw3-playground that referenced this issue May 2, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
2 participants