This repository has been archived by the owner on Jan 13, 2025. It is now read-only.
feat(select): Change root to inline-block & add fullwidth flag #5852
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![copybara-service[bot]](https://avatars.githubusercontent.com/in/44061?s=60&v=4){kind=small}
copybara-service
bot
force-pushed
the
test_307907276
branch
from
222804e to
cb6d6c8
Compare
This accommodates upcoming change which will allow the menu to automagically match width to the select anchor. As a side fix, the anchor element has been changed from `inline-flex` -> `flex` since it should always respect the width of the root element. Expect the next change to have menu auto-size its width to match select by default, thus rendering any custom sizing `demo-width-class` on the MENU to be obsolete. BREAKING CHANGE: root of mdc-select is now an inline-block element, use custom width class (i.e. `demo-width-class`) on the root instead of the anchor for width adjustments; alternately, use the new `mdc-select--fullwidth` on the root to expand width to that of its parent container PiperOrigin-RevId: 308144318
copybara-service
bot
force-pushed
the
test_307907276
branch
from
cb6d6c8 to
2673adb
Compare
This was referenced Apr 23, 2020
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
feat(select): Change root to inline-block & add fullwidth flag
This accommodates upcoming change which will allow the menu to automagically match width to the select anchor. As a side fix, the anchor element has been changed from
inline-flex->flexsince it should always respect the width of the root element.Expect the next change to have menu auto-size its width to match select by default, thus rendering any custom sizing
demo-width-classon the MENU to be obsolete.BREAKING CHANGE: root of mdc-select is now an inline-block element, use custom width class (i.e.
demo-width-class) on the root instead of the anchor for width adjustments; alternately, use the newmdc-select--fullwidthon the root to expand width to that of its parent container