Skip to content
This repository has been archived by the owner on Jan 13, 2025. It is now read-only.

feat(tab-scroller): Add incrementScrollImmediate to bypass animation #5184

Merged
merged 1 commit into from
Oct 25, 2019

Conversation

cletusw
Copy link
Contributor

@cletusw cletusw commented Oct 16, 2019

Fixes #5123

@codecov-io
Copy link

codecov-io commented Oct 16, 2019

Codecov Report

Merging #5184 into develop will increase coverage by 0.28%.
The diff coverage is 100%.

Impacted file tree graph

@@             Coverage Diff             @@
##           develop    #5184      +/-   ##
===========================================
+ Coverage    98.63%   98.91%   +0.28%     
===========================================
  Files          122      122              
  Lines         5998     6003       +5     
  Branches       772      774       +2     
===========================================
+ Hits          5916     5938      +22     
+ Misses          81       64      -17     
  Partials         1        1
Impacted Files Coverage Δ
packages/mdc-tab-scroller/foundation.ts 99.32% <100%> (+0.02%) ⬆️
packages/mdc-checkbox/component.ts 96.87% <0%> (+1.04%) ⬆️
packages/mdc-tab/component.ts 98.36% <0%> (+3.27%) ⬆️
packages/mdc-base/component.ts 100% <0%> (+3.57%) ⬆️
packages/mdc-ripple/component.ts 100% <0%> (+3.77%) ⬆️
packages/mdc-auto-init/index.ts 100% <0%> (+4.16%) ⬆️
packages/mdc-ripple/util.ts 97.56% <0%> (+4.87%) ⬆️
packages/mdc-switch/component.ts 98.27% <0%> (+6.89%) ⬆️
packages/mdc-radio/component.ts 95.83% <0%> (+8.33%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 5916d18...c455c18. Read the comment docs.

@abhiomkar
Copy link
Collaborator

@cletusw Can you please rebase your branch with origin/develop to pick up the latest lint check? Thanks!

@cletusw
Copy link
Contributor Author

cletusw commented Oct 17, 2019

@cletusw Can you please rebase your branch with origin/develop to pick up the latest lint check? Thanks!

Done!

@cletusw cletusw requested a review from patrickrodee October 17, 2019 22:25
@cletusw cletusw force-pushed the immediate branch 2 times, most recently from 8046c55 to d0483fc Compare October 18, 2019 20:02
@cletusw cletusw requested a review from patrickrodee October 18, 2019 20:03
@cletusw
Copy link
Contributor Author

cletusw commented Oct 18, 2019

Review comments fixed.

@cletusw
Copy link
Contributor Author

cletusw commented Oct 24, 2019

Review comments fixed.

Copy link
Contributor

@patrickrodee patrickrodee left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good! Thanks for working through all my comments.

@patrickrodee patrickrodee merged commit 2b878b3 into material-components:develop Oct 25, 2019
@jamesmfriedman jamesmfriedman mentioned this pull request Nov 4, 2019
93 tasks
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants