This repository has been archived by the owner on Jan 13, 2025. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 2.1k
feat(tab-scroller): Add incrementScrollImmediate to bypass animation #5184
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## develop #5184 +/- ##
===========================================
+ Coverage 98.63% 98.91% +0.28%
===========================================
Files 122 122
Lines 5998 6003 +5
Branches 772 774 +2
===========================================
+ Hits 5916 5938 +22
+ Misses 81 64 -17
Partials 1 1
Continue to review full report at Codecov.
|
patrickrodee
suggested changes
Oct 17, 2019
patrickrodee
suggested changes
Oct 17, 2019
@cletusw Can you please rebase your branch with |
Done! |
patrickrodee
suggested changes
Oct 18, 2019
8046c55
to
d0483fc
Compare
Review comments fixed. |
patrickrodee
suggested changes
Oct 24, 2019
Review comments fixed. |
patrickrodee
approved these changes
Oct 25, 2019
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good! Thanks for working through all my comments.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #5123