This repository has been archived by the owner on Jan 13, 2025. It is now read-only.
refactor(top-app-bar): Remove [de]registerEventHandler methods from adapters #4701
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Remove the top and bottom padding from the components. Remove the top and bottom margins from the button content. Button content should be center aligned. Use a <button> tag for the chip. BREAKING CHANGE: Update mdc-chip-leading-icon-margin and mdc-chip-trailing-icon-margin mixins signatures to take only left and right margin values.
…dleClick/#handleKeydown. (#4655) BREAKING CHANGE: Dialog `Foundation#handleInteraction` has been split into two methods: `#handleClick` and `#handleKeydown`.
Remove the top and bottom padding from the components. Remove the top and bottom margins from the button content. Button content should be center aligned. Use a <button> tag for the chip. BREAKING CHANGE: Update mdc-chip-leading-icon-margin and mdc-chip-trailing-icon-margin mixins signatures to take only left and right margin values.
…dleClick/#handleKeydown. (#4655) BREAKING CHANGE: Dialog `Foundation#handleInteraction` has been split into two methods: `#handleClick` and `#handleKeydown`.
…on group (#4620) BREAKING CHANGE: Replaced adapter methods getParentElement, getSelectedElementIndex with getSelectedSiblingOfItemAtIndex, isSelectableItemAtIndex.
Codecov Report
@@ Coverage Diff @@
## develop #4701 +/- ##
===========================================
+ Coverage 98.95% 98.96% +0.01%
===========================================
Files 129 129
Lines 6302 6285 -17
Branches 821 820 -1
===========================================
- Hits 6236 6220 -16
+ Misses 65 64 -1
Partials 1 1
Continue to review full report at Codecov.
|
|
All 648 screenshot tests passed for commit cc44b25 vs. |
abhiomkar
suggested changes
May 14, 2019
|
All 648 screenshot tests passed for commit 4c056e1 vs. |
|
All 648 screenshot tests passed for commit 20a6ce0 vs. |
abhiomkar
suggested changes
May 15, 2019
abhiomkar
changed the title
abhiomkar
reviewed
May 15, 2019
abhiomkar
reviewed
May 15, 2019
|
All 693 screenshot tests passed for commit 1e08cb9 vs. |
|
All 693 screenshot tests passed for commit 7de95ed vs. |
abhiomkar
reviewed
May 16, 2019
| @@ -21,7 +21,6 @@ | |||
| * THE SOFTWARE. | |||
| */ | |||
|
|
|||
| import {MDCTopAppBarAdapter} from '../adapter'; | |||
There was a problem hiding this comment.
Seems like the coverage score went down, can we aim to have 100% test coverage?
|
All 693 screenshot tests passed for commit 12608df vs. |
|
All 693 screenshot tests passed for commit f16c067 vs. |
moog16
pushed a commit
that referenced
this pull request
May 28, 2019
…dapters (#4701) BREAKING CHANGE: Replaced adapter methods getParentElement, getSelectedElementIndex with getSelectedSiblingOfItemAtIndex, isSelectableItemAtIndex.
moog16
pushed a commit
that referenced
this pull request
Jun 3, 2019
…dapters (#4701) BREAKING CHANGE: Replaced adapter methods getParentElement, getSelectedElementIndex with getSelectedSiblingOfItemAtIndex, isSelectableItemAtIndex.
abhiomkar
pushed a commit
that referenced
this pull request
Jun 11, 2019
…dapters (#4701) BREAKING CHANGE: Replaced adapter methods getParentElement, getSelectedElementIndex with getSelectedSiblingOfItemAtIndex, isSelectableItemAtIndex.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
related #4527 & #2813
BREAKING CHANGE: remove adapter methods registerNavigationIconInteractionHandler, deregisterNavigationIconInteractionHandler, registerScrollHandler, deregisterScrollHandler, registerResizeHandler, deregisterResizeHandler.