Update lolex to the latest version 🚀 #3507
Conversation
![greenkeeper[bot]](https://avatars.githubusercontent.com/in/505?s=60&v=4){kind=small}
Version 2.7.3 just got published.Update to this version instead 🚀 CommitsThe new version differs by 6 commits.
See the full diff |
Version 2.7.4 just got published.Update to this version instead 🚀 CommitsThe new version differs by 6 commits.
See the full diff |
Update to this version instead 🚀 CommitsThe new version differs by 9 commits.
See the full diff |
Update to this version instead 🚀 CommitsThe new version differs by 18 commits.
There are 18 commits in total. See the full diff |
|
All 557 screenshot tests passed for commit 2a8f65d vs. |
|
All 557 screenshot tests passed for commit e312180 vs. |
|
All 557 screenshot tests passed for commit e312180 vs. |
|
All 557 screenshot tests passed for commit ca095c9 vs. |
|
All 557 screenshot tests passed for commit ca095c9 vs. |
…eenkeeper/lolex-2.7.2 chore: merge with upstream branch
….7.2 chore: merge with master branch
|
Fixed bunch of tests with following:
Karma test times out without any useful error message. Still need investigation if we're not calling Investigate if we can use lolex's to mock rAF and replace all calls to |
|
All 557 screenshot tests passed for commit dcbca37 vs. |
|
All 557 screenshot tests passed for commit d8d60b3 vs. |
FIXME: One ripple test is failing which suggests things aren't working as intended...
|
I pushed an Currently one test fails on the branch, but that failure suggests that something might not be operating quite like we expect it to with lolex used for both timeouts and rAFs. |
Codecov Report
@@ Coverage Diff @@
## master #3507 +/- ##
=========================================
Coverage ? 98.67%
=========================================
Files ? 126
Lines ? 5594
Branches ? 746
=========================================
Hits ? 5520
Misses ? 74
Partials ? 0Continue to review full report at Codecov.
|
|
All 652 screenshot tests passed for commit f3c4fca vs. |
|
All 652 screenshot tests passed for commit b3ca1ec vs. |
kfranqueiro
force-pushed
the
greenkeeper/lolex-2.7.2
branch
from
b3ca1ec to
e2d7659
Compare
|
All 652 screenshot tests passed for commit e2d7659 vs. |
This updates lolex to 3.0.0, which now covers rAF as well, so createMockRaf has been removed. `clock.runToFrame()` replaces `mockRaf.flush()`, and `clock.countTimers()` replaces `mockRaf.pendingFrames.length`. This also creates a centralized `test/unit/helpers/clock` module to avoid any missed cleanup of mocked timeout/rAF functions. Instead of using lolex directly in unit tests, import the clock module's `install` function and call that. It creates a lolex instance and stores it within the module, and there is a "global" afterEach set up to uninstall it if it exists, after every test in every suite. (cherry picked from commit 7c60849)
Version 2.7.2 of lolex was just published.
The version 2.7.2 is not covered by your current version range.
If you don’t accept this pull request, your project will work just like it did before. However, you might be missing out on a bunch of new features, fixes and/or performance improvements from the dependency update.
It might be worth looking into these changes and trying to get this project onto the latest version of lolex.
If you have a solid test suite and good coverage, a passing build is a strong indicator that you can take advantage of these changes directly by merging the proposed change into your project. If the build fails or you don’t have such unconditional trust in your tests, this branch is a great starting point for you to work on the update.
Commits
The new version differs by 101 commits.
7f398ea2.7.2150eee0Prepare for new release4911e15fix(setInterval): parsetimeoutarg to integer (#202)45cf2fbMerge pull request #196 from mroderick/npm-auditadf8886Upgrade sinon and referee6dc6eefUpgrade insecure dependencies with npm audit fixf758e902.7.179f9431Merge pull request #195 from sinonjs/fix-performance-replacement-on-ios-90cfb45eFix performance replacement on iOS 9.34f452caUpdate to latest Sinonef9332bMerge pull request #193 from icebob/master8fa1bceadd.refreshto timer object.a13afb9fixes #191 - ref(), unref() return value on NodeJS8a30ce6Add Safari 9 to list of Sauce Labs browsers6dace232.7.0There are 101 commits in total.
See the full diff
FAQ and help
There is a collection of frequently asked questions. If those don’t help, you can always ask the humans behind Greenkeeper.
Your Greenkeeper bot 🌴