This repository has been archived by the owner on Jan 13, 2025. It is now read-only.
feat(tab): Move event registration to component #3331
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
All 344 screenshot tests passed for commit d83a862 vs. |
Codecov Report
@@ Coverage Diff @@
## master #3331 +/- ##
==========================================
- Coverage 98.06% 98.05% -0.01%
==========================================
Files 120 120
Lines 5155 5143 -12
Branches 644 643 -1
==========================================
- Hits 5055 5043 -12
Misses 100 100
Continue to review full report at Codecov.
|
|
All 337 screenshot tests passed for commit ce234e3 vs. |
|
All 337 screenshot tests passed for commit e91c56f vs. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Also removes unnecessary
animatingclasses andtransitionendhandler.Refs #2813 for Tab.
Fixes #3316.
BREAKING CHANGE: Removes handleTransitionEnd foundation API. Removes [de]registerEventHandler adapter API. Event registration is now the component's responsibility.