This repository has been archived by the owner on Jan 13, 2025. It is now read-only.
fix(list): Update clickable elements selector #3312
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ate readme example tabindex
|
All 188 screenshot tests passed for commit 93c8546 vs. |
Codecov Report
@@ Coverage Diff @@
## master #3312 +/- ##
=======================================
Coverage 98.03% 98.03%
=======================================
Files 120 120
Lines 5184 5184
Branches 649 649
=======================================
Hits 5082 5082
Misses 102 102
Continue to review full report at Codecov.
|
|
All 188 screenshot tests passed for commit 6c31158 vs. |
YuoMamoru
pushed a commit
to YuoMamoru/material-components-web
that referenced
this pull request
Aug 14, 2018
(cherry picked from commit c8ded0a)
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Updates the enabled items selector to search for descendant elements of
.mdc-list-iteminstead of allaandbuttonelements.Updates Readme demo to show
tabindex=0for the first element that should be in tab order for single selection lists.Updates the list component to default to vertical list if
aria-orientationis not present or is misspelled.Adds unit test for instantiating the component with various
aria-orientationvalues.