Skip to content
This repository has been archived by the owner on Jan 13, 2025. It is now read-only.

docs(fab): Remove trailing whitespace from material icons #2827

Merged
merged 2 commits into from
May 29, 2018

Conversation

kfranqueiro
Copy link
Contributor

IE vertically displaces icons from the Material Icons font if there is trailing whitespace after the text content intended to render the icon.

This fixes all instances of mdc-fab__icon material-icons to put the entire element on one line, in docs and demos and screenshot tests.

Fixes #2752.

@kfranqueiro kfranqueiro requested a review from williamernest May 25, 2018 21:30
@codecov-io
Copy link

codecov-io commented May 25, 2018

Codecov Report

Merging #2827 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #2827   +/-   ##
=======================================
  Coverage   98.42%   98.42%           
=======================================
  Files          98       98           
  Lines        4203     4203           
  Branches      534      534           
=======================================
  Hits         4137     4137           
  Misses         66       66

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 3f6bbc1...863abe0. Read the comment docs.

Copy link
Contributor

@williamernest williamernest left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@kfranqueiro kfranqueiro merged commit 6722638 into master May 29, 2018
@kfranqueiro kfranqueiro deleted the docs/fab-no-icon-space branch May 29, 2018 13:40
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

FAB: Material icon font not vertically centered in IE 11...sometimes?
3 participants