refactor(select): use line ripple #2544
Conversation
moog16
changed the base branch from
master
to
refactor/select/floating-label-replacement
moog16
changed the base branch from
refactor/select/floating-label-replacement
to
refactor/select/use-floating-label
Codecov Report
@@ Coverage Diff @@
## master #2544 +/- ##
==========================================
- Coverage 98.62% 98.61% -0.01%
==========================================
Files 101 98 -3
Lines 4210 4187 -23
Branches 532 532
==========================================
- Hits 4152 4129 -23
Misses 58 58
Continue to review full report at Codecov.
|
packages/mdc-select/_mixins.scss
Outdated
| @@ -76,18 +82,26 @@ | |||
| } | |||
|
|
|||
| @mixin mdc-select-bottom-line-color_($color) { | |||
| .mdc-select__bottom-line { | |||
| @include mdc-select-bottom-line-fill-color($color); | |||
| .mdc-line-ripple { | |||
There was a problem hiding this comment.
I dont think you need to set the mdc-line-ripple here
packages/mdc-select/_mixins.scss
Outdated
| } | ||
|
|
||
| .mdc-select__bottom-line::after { | ||
| @include mdc-select-bottom-line-fill-color($color); | ||
| .mdc-line-ripple::after { |
There was a problem hiding this comment.
::after?? whats this for?
There was a problem hiding this comment.
Not sure what it was even doing before. Removing the rule.
packages/mdc-select/constants.js
Outdated
| @@ -26,7 +26,7 @@ export const numbers = { | |||
|
|
|||
| export const strings = { | |||
| CHANGE_EVENT: 'MDCSelect:change', | |||
| BOTTOM_LINE_SELECTOR: '.mdc-select__bottom-line', | |||
| BOTTOM_LINE_SELECTOR: '.mdc-line-ripple', | |||
There was a problem hiding this comment.
rename this to LINE_RIPPLE_SELECTOR?
| @@ -21,7 +21,7 @@ import {assert} from 'chai'; | |||
| import {MDCFloatingLabel} from '../../../packages/mdc-floating-label/index'; | |||
|
|
|||
| const getFixture = () => bel` | |||
| <div class="mdc-floating-label"></div> | |||
| <label class="mdc-floating-label"></label> | |||
There was a problem hiding this comment.
I think this change snuck in here
There was a problem hiding this comment.
This is done on purpose. You're right in that it is more related to the floating label PR, but it wasn't caught until doing changes with line-ripple.
moog16
changed the base branch from
refactor/select/use-floating-label
to
master
fixes #2129