This repository has been archived by the owner on Jan 13, 2025. It is now read-only.
fix(text-field): Fix floating label for Outlined w/ leading icon #2078
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #2078 +/- ##
=======================================
Coverage 99.46% 99.46%
=======================================
Files 84 84
Lines 3722 3722
Branches 480 480
=======================================
Hits 3702 3702
Misses 20 20Continue to review full report at Codecov.
|
…ined-icon Merge from master to pickup file rename (label/_variables.css -> label/_variables.scss).
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Replaces translateX percentage values with absolute pixel values. The goal here is to shift the label horizontally back towards the leading edge of the Text Field, since the leading icon shifts the label towards the trailing edge. Since it was shifted a fix amount, just shift it back the same fixed amount.
Fixes #1908