Skip to content
This repository has been archived by the owner on Jan 13, 2025. It is now read-only.

fix(list): Lists have incorrect padding #1523

Merged
merged 1 commit into from
Nov 18, 2017
Merged

fix(list): Lists have incorrect padding #1523

merged 1 commit into from
Nov 18, 2017

Conversation

touficbatache
Copy link
Contributor

Fixes and closes #1488

@codecov-io
Copy link

codecov-io commented Nov 1, 2017

Codecov Report

Merging #1523 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #1523   +/-   ##
=======================================
  Coverage   99.82%   99.82%           
=======================================
  Files          69       69           
  Lines        3392     3392           
  Branches      424      424           
=======================================
  Hits         3386     3386           
  Misses          6        6

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update bcc5ec5...a326817. Read the comment docs.

Copy link
Contributor

@lynnmercier lynnmercier left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, and I checked with our designers.

Both Drawer and Menu use mdc-list within their structure...but both of them override this padding style. So this change has no effect on Drawer or Menu

@lynnmercier lynnmercier merged commit cd03a0e into material-components:master Nov 18, 2017
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Lists have incorrect padding
3 participants