Skip to content
This repository has been archived by the owner on Jan 13, 2025. It is now read-only.

fix(slider): Change how step value is initialized (#1173) #1245

Merged
merged 1 commit into from
Sep 7, 2017

Conversation

archnode
Copy link
Contributor

@archnode archnode commented Sep 6, 2017

resolves #1173

Micro-change, but the "setStep"-function actually triggers a "setValue" which sets aria-valuenow to null since the value is still uninitialized at this time.

(Sorry, had to recreate my previous pr)

@googlebot
Copy link

We found a Contributor License Agreement for you (the sender of this pull request), but were unable to find agreements for the commit author(s). If you authored these, maybe you used a different email address in the git commits than was used to sign the CLA (login here to double check)? If these were authored by someone else, then they will need to sign a CLA as well, and confirm that they're okay with these being contributed to Google.
In order to pass this check, please resolve this problem and have the pull request author add another comment and the bot will run again.

@codecov-io
Copy link

codecov-io commented Sep 6, 2017

Codecov Report

Merging #1245 into master will not change coverage.
The diff coverage is 100%.

Impacted file tree graph

@@          Coverage Diff           @@
##           master   #1245   +/-   ##
======================================
  Coverage    99.9%   99.9%           
======================================
  Files          69      69           
  Lines        3307    3307           
  Branches      407     407           
======================================
  Hits         3304    3304           
  Misses          3       3
Impacted Files Coverage Δ
packages/mdc-slider/foundation.js 100% <100%> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 3b51f28...abb9e5d. Read the comment docs.

Copy link
Contributor

@yeelan0319 yeelan0319 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the fix! 💯

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Slider: Discrete slider not initializing current value
4 participants