Skip to content
This repository has been archived by the owner on Jan 13, 2025. It is now read-only.

fix(slider): Change how step value is initialized #1182

Closed
wants to merge 2 commits into from
Closed

fix(slider): Change how step value is initialized #1182

wants to merge 2 commits into from

Conversation

archnode
Copy link
Contributor

resolves #1173

Micro-change, but the "setStep"-function actually triggers a "setValue" which sets aria-valuenow to null since the value is still uninitialized at this time.

@googlebot
Copy link

Thanks for your pull request. It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

📝 Please visit https://cla.developers.google.com/ to sign.

Once you've signed, please reply here (e.g. I signed it!) and we'll verify. Thanks.


  • If you've already signed a CLA, it's possible we don't have your GitHub username or you're using a different email address. Check your existing CLA data and verify that your email is set on your git commits.
  • If your company signed a CLA, they designated a Point of Contact who decides which employees are authorized to participate. You may need to contact the Point of Contact for your company and ask to be added to the group of authorized contributors. If you don't know who your Point of Contact is, direct the project maintainer to go/cla#troubleshoot.
  • In order to pass this check, please resolve this problem and have the pull request author add another comment and the bot will run again.

@archnode
Copy link
Contributor Author

I signed, I signed ..

@googlebot
Copy link

We found a Contributor License Agreement for you (the sender of this pull request), but were unable to find agreements for the commit author(s). If you authored these, maybe you used a different email address in the git commits than was used to sign the CLA (login here to double check)? If these were authored by someone else, then they will need to sign a CLA as well, and confirm that they're okay with these being contributed to Google.
In order to pass this check, please resolve this problem and have the pull request author add another comment and the bot will run again.

@codecov-io
Copy link

codecov-io commented Aug 24, 2017

Codecov Report

Merging #1182 into master will not change coverage.
The diff coverage is 100%.

Impacted file tree graph

@@          Coverage Diff           @@
##           master   #1182   +/-   ##
======================================
  Coverage    99.9%   99.9%           
======================================
  Files          69      69           
  Lines        3306    3306           
  Branches      406     406           
======================================
  Hits         3303    3303           
  Misses          3       3
Impacted Files Coverage Δ
packages/mdc-slider/foundation.js 100% <100%> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update fc71843...a4ecc31. Read the comment docs.

@lynnmercier
Copy link
Contributor

This generally looks good, but please add a test to cover this case.

And @archnode, our Googlebot still wants you to sign the CLA

Copy link
Contributor

@lynnmercier lynnmercier left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please add a test for this case

@lynnmercier lynnmercier self-assigned this Sep 1, 2017
@archnode archnode closed this Sep 6, 2017
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Slider: Discrete slider not initializing current value
4 participants