Skip to content
This repository has been archived by the owner on Jan 13, 2025. It is now read-only.

Text Field textarea screenshot test page is flaky in Edge #4176

Closed
acdvorak opened this issue Dec 13, 2018 · 0 comments
Closed

Text Field textarea screenshot test page is flaky in Edge #4176

acdvorak opened this issue Dec 13, 2018 · 0 comments
Assignees
@acdvorak
Labels
bug
Milestone
v0.43.0

Comments

@acdvorak
Copy link
Contributor

Issue

mdc-textfield/issues/3332.html flakes in Edge on almost every screenshot test run.

It's currently preventing me from submitting #4166.

I'm guessing that #4035 accidentally merged a flaky screenshot image.

Examples

image

Solution

We need to redact the label text in Edge by adding test-container--edge-fonts and
test-font--redact-all classes.
@acdvorak acdvorak added the bug label Dec 13, 2018
@acdvorak acdvorak added this to the v0.43.0 milestone Dec 13, 2018
@acdvorak acdvorak self-assigned this Dec 13, 2018
acdvorak added a commit that referenced this issue Dec 13, 2018
@acdvorak
chore(text-field): Fix flaky screenshot test in Edge
ffe371e 
Fixes #4176
@acdvorak acdvorak mentioned this issue Dec 13, 2018
Merged
acdvorak added a commit that referenced this issue Dec 13, 2018
@acdvorak
chore(text-field): Fix flaky screenshot test in Edge (#4177)
08e25f9 
Fixes #4176
adrianschmidt pushed a commit to Lundalogik/material-components-web that referenced this issue Jan 4, 2019
@acdvorak
chore(text-field): Fix flaky screenshot test in Edge (material-compon…
c5ce09e 
…ents#4177)

Fixes material-components#4176

(cherry picked from commit 08e25f9)
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@acdvorak acdvorak

Labels
bug
Projects
None yet
Milestone
v0.43.0
Development

No branches or pull requests
1 participant
@acdvorak