Skip to content
This repository has been archived by the owner on Jan 13, 2025. It is now read-only.

Commit

Permalink
fix(menu): Only show scrollbar when menu item is too big
Browse files Browse the repository at this point in the history
Also fixes select's menu

Resolves #1247
  • Loading branch information
RobJacobs authored and lynnmercier committed Sep 22, 2017
1 parent 7c43b7c commit fe7d4c8
Show file tree
Hide file tree
Showing 2 changed files with 2 additions and 2 deletions.
3 changes: 2 additions & 1 deletion packages/mdc-menu/simple/mdc-simple-menu.scss
Original file line number Diff line number Diff line change
Expand Up @@ -37,7 +37,8 @@ $mdc-simple-menu-item-fade-duration: .3s;
background-color: white;
white-space: nowrap;
opacity: 0;
overflow: hidden;
overflow-x: hidden;
overflow-y: auto;
box-sizing: border-box;
will-change: transform, opacity;
z-index: 4;
Expand Down
1 change: 0 additions & 1 deletion packages/mdc-select/mdc-select.scss
Original file line number Diff line number Diff line change
Expand Up @@ -85,7 +85,6 @@
left: 0;
max-height: 100%;
transform-origin: center center;
overflow-y: scroll;
z-index: 4; // Should pop up above everything else. temporary-drawer is next highest at 3.
}

Expand Down

1 comment on commit fe7d4c8

@trimox
Copy link
Contributor

@trimox trimox commented on fe7d4c8 Sep 25, 2017

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Posted originally on #1247
I'm pretty sure a scrollbar is going to be displayed while the menu is transitioning to an open state, and if the list is short the scrollbar will suddenly disappear. Not sure if that was intended or not?

Please sign in to comment.