el9toel10: mysql: fix tests and syntax errors

repos/system_upgrade/el9toel10/actors/mysql/checkmysql/libraries/checkmysql.py

@@ -104,7 +104,7 @@ def _generate_deprecated_config_report(found_options: list,
         reporting.RelatedResource('file', '/etc/systemd/system/mysqld.service.d/override.conf'),
         reporting.Remediation(hint=(
             'To ensure smooth upgrade process it is strongly recommended to:{}'
-            .format(''.join(''._formatted_list_output(remedy_list)))
+            .format(''.join(_formatted_list_output(remedy_list)))
         )),
         ])
 
@@ -120,8 +120,8 @@ def _generate_report(found_options: list, found_arguments: list) -> None:
 
     if found_arguments or found_options:
         _generate_deprecated_config_report(found_options, found_arguments)
-    else:
-        _generate_mysql_present_report()
+
+    _generate_mysql_present_report()
 
 
 def process() -> None:

repos/system_upgrade/el9toel10/actors/mysql/checkmysql/tests/test_checkmysql.py

@@ -59,14 +59,6 @@ def consume_mocked(*args, **kwargs):
     # Check that we have made a report
     assert len(reporting.create_report.reports) == 1
 
-    r = _find_hint(reporting.create_report.reports[0])
-
-    # Check that Hint was in the report
-    assert r is not None
-
-    assert ('Following incompatible configuration options'
-            not in r)
-
 
 def test_process_deprecated(monkeypatch):
     def consume_mocked(*args, **kwargs):
@@ -80,10 +72,18 @@ def consume_mocked(*args, **kwargs):
     checkmysql.process()
 
     # Check that we have made a report
-    assert len(reporting.create_report.reports) == 1
+    assert len(reporting.create_report.reports) == 2
+
+    # Find deprecation report
+    found = None
+    for rep in reporting.create_report.reports:
+        if rep['title'] == 'Detected incompatible MySQL configuration':
+            found = rep
+            break
+
+    assert found is not None
 
-    # Find first hint message in remediations
-    r = _find_hint(reporting.create_report.reports[0])
+    r = found['summary']
 
     # Check that Hint was in the report
     assert r is not None